Re: [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility

[Christian Ebner <c.ebner@proxmox.com>]

On 9/30/25 1:49 PM, Wolfgang Bumiller wrote:
> On Tue, Sep 30, 2025 at 10:02:01AM +0200, Christian Ebner wrote:
>> This patches fix the ticket parsing when login to instances of PBS version 3
>> or lower. For this, the current pve_compat flags for `Login` and `Client`
>> are refactored to be an extendable enum variant instead, adding the ticket
>> parsing backwards compatibility. In that compatibility mode, response parsing
>> of the ticket does not interpret the presence of the `ticket-info` field as the
>> ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4
>> compatible parsing, as the client never used `http-only` tickets.
> 
> I thought this field was introduced only with http-only tickets, so why
> is it not a reliable indicator and shouldn't *that* be fixed instead?

I'm not so familiar with the actual code and the changes over time here, 
so that might as well be the case.

AFAIK there are however PBS 3.x versions out there which do return the 
field also on non http-only tickets, the changes introduced by [0] back 
in March. So it only would be required to backport/build based on this 
[1] patch for stable-3 then?

However, older patch level versions would still not work regardless.

[0] 
https://git.proxmox.com/?p=proxmox.git;a=commit;h=6a7f6317093285a1494c4ebace71c71697058587
[1] 
https://git.proxmox.com/?p=proxmox.git;a=commit;h=8d01d274231f5b7172b519104a8042f92ace8e1e


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel