public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v5 1/6] remote tasks: implement improved cache for remote tasks
Date: Tue, 1 Jul 2025 12:02:44 +0200	[thread overview]
Message-ID: <41d1b3fa-e348-455f-9a98-c60180044d6a@proxmox.com> (raw)
In-Reply-To: <1df410bd-badc-45db-8a9e-a1292d8532d5@proxmox.com>



On  2025-05-14 16:08, Dominik Csapak wrote:
> Just started to review the series, and wanted to say that
> I'll give some early feedback on this one before diving into the
> others.
> 
> (sorry if i mention something that was already mentioned in a previous
> iteration, just throw it back to me should that happen ;) )
> 
> On a high level: Looks mostly good to me, besides a few smaller things inline
> and the following:
> 

Thanks a lot for the review and sorry for the long wait. I didn't really keep a close eye on the
pdm-devel list in the last few weeks because I was busy with other stuff relevant to the upcoming
major releases. I also only saw your replies a couple days ago since I was not in CC (CC'd mails land
directly in my inbox vs the pdm-devel folder, where Thunderbird makes it not really easy to see
new messages in collapsed threads).

I'll answer with some more detail soon, I have to think through your suggestions and also brush up
my own memories about my approach/code.


Thanks!

-- 
- Lukas



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-07-01 10:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 11:41 [pdm-devel] [PATCH proxmox-datacenter-manager v5 0/6] remote task cache fetching task / better cache backend Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 1/6] remote tasks: implement improved cache for remote tasks Lukas Wagner
2025-05-14 14:08   ` Dominik Csapak
2025-07-01 10:02     ` Lukas Wagner [this message]
2025-07-03  8:05     ` Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 2/6] remote tasks: add background task for task polling, use new task cache Lukas Wagner
2025-05-14 15:27   ` Dominik Csapak
2025-07-03  8:05     ` Lukas Wagner
2025-07-03 11:25       ` Dominik Csapak
2025-07-09 11:22       ` Lukas Wagner
2025-07-09 11:35         ` Dominik Csapak
2025-07-09 12:25           ` Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 3/6] remote tasks: improve locking for task archive iterator Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 4/6] pdm-api-types: remote tasks: add new_from_str constructor for TaskStateType Lukas Wagner
2025-05-15  6:56   ` Dominik Csapak
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 5/6] fake remote: make the fake_remote feature compile again Lukas Wagner
2025-05-15  6:55   ` Dominik Csapak
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 6/6] fake remote: clippy fixes Lukas Wagner
2025-05-15  7:05   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41d1b3fa-e348-455f-9a98-c60180044d6a@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal