public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager] ui: tree-wide: fix spelling of show-task_progress() function
Date: Wed, 17 Jun 2026 15:46:24 +0200	[thread overview]
Message-ID: <3a5e9a82-942f-42d7-8f4c-e520e96bdb7b@proxmox.com> (raw)
In-Reply-To: <20260617124115.258184-1-s.sterz@proxmox.com>

needed that for testing building with yew-comp from master
so consider this (not applying since it's not bumped yet..)

thanks!

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 6/17/26 2:40 PM, Shannon Sterz wrote:
> the commit 51a9489dd418 (loadable component: fix show_task_progress
> method name spelling) fixed the name of this function. adapt to it so
> pdm ui will build against yew-comp once this change is bumped.
> 
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> 
> Notes:
>      i know the change this is adapting to isn't bumped yet, so applying it
>      before that will break the build. however, i could not find anything
>      like this on list [1] so i thought i'll send a fix for this before
>      it's accidentally missed.
>      
>      [1]: https://lore.proxmox.com/all/?q=show_task_progres
> 
>   ui/src/configuration/subscription_registry.rs | 2 +-
>   ui/src/guests.rs                              | 2 +-
>   ui/src/pve/tree.rs                            | 6 +++---
>   ui/src/remotes/updates.rs                     | 2 +-
>   ui/src/widget/snapshot_window.rs              | 2 +-
>   5 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
> index 470789bc..32343c15 100644
> --- a/ui/src/configuration/subscription_registry.rs
> +++ b/ui/src/configuration/subscription_registry.rs
> @@ -885,7 +885,7 @@ impl LoadableComponent for SubscriptionRegistryComp {
>                           Ok(None) => link.change_view(None),
>                           Ok(Some(upid)) => {
>                               link.change_view(None);
> -                            link.show_task_progres(upid);
> +                            link.show_task_progress(upid);
>                           }
>                           Err(err) => link.show_error(tr!("Apply Pending"), err.to_string(), true),
>                       }
> diff --git a/ui/src/guests.rs b/ui/src/guests.rs
> index f11f0de5..ef670a00 100644
> --- a/ui/src/guests.rs
> +++ b/ui/src/guests.rs
> @@ -340,7 +340,7 @@ impl LoadableComponent for GuestPanelComp {
>                   // another remote that ran concurrently cannot point the task
>                   // viewer at the wrong remote
>                   self.set_task_base_url(format!("/pve/remotes/{}/tasks", upid.remote()).into());
> -                ctx.link().show_task_progres(upid.to_string());
> +                ctx.link().show_task_progress(upid.to_string());
>               }
>               Msg::GuestAction(action, key) => {
>                   let Some(entry) = self.store.read().lookup_record(&key).cloned() else {
> diff --git a/ui/src/pve/tree.rs b/ui/src/pve/tree.rs
> index 7a14a05b..0042331c 100644
> --- a/ui/src/pve/tree.rs
> +++ b/ui/src/pve/tree.rs
> @@ -362,7 +362,7 @@ impl LoadableComponent for PveTreeComp {
>                           };
>   
>                           match res {
> -                            Ok(upid) => link.show_task_progres(upid.to_string()),
> +                            Ok(upid) => link.show_task_progress(upid.to_string()),
>                               Err(err) => link.show_error(tr!("Error"), err.to_string(), true),
>                           }
>                       }),
> @@ -386,7 +386,7 @@ impl LoadableComponent for PveTreeComp {
>                           };
>   
>                           match res {
> -                            Ok(upid) => link.show_task_progres(upid.to_string()),
> +                            Ok(upid) => link.show_task_progress(upid.to_string()),
>                               Err(err) => link.show_error(tr!("Error"), err.to_string(), true),
>                           }
>                       }),
> @@ -566,7 +566,7 @@ impl LoadableComponent for PveTreeComp {
>                       .on_close(ctx.link().change_view_callback(|_| None))
>                       .on_submit({
>                           let link = ctx.link().clone();
> -                        move |upid: RemoteUpid| link.show_task_progres(upid.to_string())
> +                        move |upid: RemoteUpid| link.show_task_progress(upid.to_string())
>                       })
>                       .into(),
>               ),
> diff --git a/ui/src/remotes/updates.rs b/ui/src/remotes/updates.rs
> index dbb9f700..0aca00e6 100644
> --- a/ui/src/remotes/updates.rs
> +++ b/ui/src/remotes/updates.rs
> @@ -428,7 +428,7 @@ impl LoadableComponent for UpdateTreeComponent {
>   
>                       match client.refresh_remote_update_summary().await {
>                           Ok(upid) => {
> -                            link.show_task_progres(upid.to_string());
> +                            link.show_task_progress(upid.to_string());
>                           }
>                           Err(err) => {
>                               link.show_error(tr!("Could not refresh update status."), err, false);
> diff --git a/ui/src/widget/snapshot_window.rs b/ui/src/widget/snapshot_window.rs
> index b14b912f..71b0bc01 100644
> --- a/ui/src/widget/snapshot_window.rs
> +++ b/ui/src/widget/snapshot_window.rs
> @@ -228,7 +228,7 @@ impl PdmSnapshotWindow {
>           self.set_task_base_url(
>               format!("/{}/remotes/{}/tasks", upid.remote_type(), upid.remote()).into(),
>           );
> -        ctx.link().show_task_progres(upid.to_string());
> +        ctx.link().show_task_progress(upid.to_string());
>       }
>   
>       fn create_input_panel(guest_type: GuestType) -> InputPanel {





      reply	other threads:[~2026-06-17 13:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 12:41 [PATCH datacenter-manager] ui: tree-wide: fix spelling of show-task_progress() function Shannon Sterz
2026-06-17 13:46 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a5e9a82-942f-42d7-8f4c-e520e96bdb7b@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal