From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4D1461FF14F for ; Wed, 17 Jun 2026 15:46:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C5CE53713C; Wed, 17 Jun 2026 15:46:29 +0200 (CEST) Message-ID: <3a5e9a82-942f-42d7-8f4c-e520e96bdb7b@proxmox.com> Date: Wed, 17 Jun 2026 15:46:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH datacenter-manager] ui: tree-wide: fix spelling of show-task_progress() function To: Shannon Sterz , pdm-devel@lists.proxmox.com References: <20260617124115.258184-1-s.sterz@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260617124115.258184-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781703928068 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CD4YRNJDF2UDB2D2YI746ZBPW2YRZAIA X-Message-ID-Hash: CD4YRNJDF2UDB2D2YI746ZBPW2YRZAIA X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: needed that for testing building with yew-comp from master so consider this (not applying since it's not bumped yet..) thanks! Reviewed-by: Dominik Csapak On 6/17/26 2:40 PM, Shannon Sterz wrote: > the commit 51a9489dd418 (loadable component: fix show_task_progress > method name spelling) fixed the name of this function. adapt to it so > pdm ui will build against yew-comp once this change is bumped. > > Signed-off-by: Shannon Sterz > --- > > Notes: > i know the change this is adapting to isn't bumped yet, so applying it > before that will break the build. however, i could not find anything > like this on list [1] so i thought i'll send a fix for this before > it's accidentally missed. > > [1]: https://lore.proxmox.com/all/?q=show_task_progres > > ui/src/configuration/subscription_registry.rs | 2 +- > ui/src/guests.rs | 2 +- > ui/src/pve/tree.rs | 6 +++--- > ui/src/remotes/updates.rs | 2 +- > ui/src/widget/snapshot_window.rs | 2 +- > 5 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs > index 470789bc..32343c15 100644 > --- a/ui/src/configuration/subscription_registry.rs > +++ b/ui/src/configuration/subscription_registry.rs > @@ -885,7 +885,7 @@ impl LoadableComponent for SubscriptionRegistryComp { > Ok(None) => link.change_view(None), > Ok(Some(upid)) => { > link.change_view(None); > - link.show_task_progres(upid); > + link.show_task_progress(upid); > } > Err(err) => link.show_error(tr!("Apply Pending"), err.to_string(), true), > } > diff --git a/ui/src/guests.rs b/ui/src/guests.rs > index f11f0de5..ef670a00 100644 > --- a/ui/src/guests.rs > +++ b/ui/src/guests.rs > @@ -340,7 +340,7 @@ impl LoadableComponent for GuestPanelComp { > // another remote that ran concurrently cannot point the task > // viewer at the wrong remote > self.set_task_base_url(format!("/pve/remotes/{}/tasks", upid.remote()).into()); > - ctx.link().show_task_progres(upid.to_string()); > + ctx.link().show_task_progress(upid.to_string()); > } > Msg::GuestAction(action, key) => { > let Some(entry) = self.store.read().lookup_record(&key).cloned() else { > diff --git a/ui/src/pve/tree.rs b/ui/src/pve/tree.rs > index 7a14a05b..0042331c 100644 > --- a/ui/src/pve/tree.rs > +++ b/ui/src/pve/tree.rs > @@ -362,7 +362,7 @@ impl LoadableComponent for PveTreeComp { > }; > > match res { > - Ok(upid) => link.show_task_progres(upid.to_string()), > + Ok(upid) => link.show_task_progress(upid.to_string()), > Err(err) => link.show_error(tr!("Error"), err.to_string(), true), > } > }), > @@ -386,7 +386,7 @@ impl LoadableComponent for PveTreeComp { > }; > > match res { > - Ok(upid) => link.show_task_progres(upid.to_string()), > + Ok(upid) => link.show_task_progress(upid.to_string()), > Err(err) => link.show_error(tr!("Error"), err.to_string(), true), > } > }), > @@ -566,7 +566,7 @@ impl LoadableComponent for PveTreeComp { > .on_close(ctx.link().change_view_callback(|_| None)) > .on_submit({ > let link = ctx.link().clone(); > - move |upid: RemoteUpid| link.show_task_progres(upid.to_string()) > + move |upid: RemoteUpid| link.show_task_progress(upid.to_string()) > }) > .into(), > ), > diff --git a/ui/src/remotes/updates.rs b/ui/src/remotes/updates.rs > index dbb9f700..0aca00e6 100644 > --- a/ui/src/remotes/updates.rs > +++ b/ui/src/remotes/updates.rs > @@ -428,7 +428,7 @@ impl LoadableComponent for UpdateTreeComponent { > > match client.refresh_remote_update_summary().await { > Ok(upid) => { > - link.show_task_progres(upid.to_string()); > + link.show_task_progress(upid.to_string()); > } > Err(err) => { > link.show_error(tr!("Could not refresh update status."), err, false); > diff --git a/ui/src/widget/snapshot_window.rs b/ui/src/widget/snapshot_window.rs > index b14b912f..71b0bc01 100644 > --- a/ui/src/widget/snapshot_window.rs > +++ b/ui/src/widget/snapshot_window.rs > @@ -228,7 +228,7 @@ impl PdmSnapshotWindow { > self.set_task_base_url( > format!("/{}/remotes/{}/tasks", upid.remote_type(), upid.remote()).into(), > ); > - ctx.link().show_task_progres(upid.to_string()); > + ctx.link().show_task_progress(upid.to_string()); > } > > fn create_input_panel(guest_type: GuestType) -> InputPanel {