public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pdm-devel] [PATCH manager/proxmox{-api-types, -yew-comp, -datacenter-manager} 00/10] PVE node update view
Date: Wed, 3 Sep 2025 12:20:00 +0200	[thread overview]
Message-ID: <3611b960-62d6-4583-83c9-557dd0fb16b7@proxmox.com> (raw)
In-Reply-To: <20250902151427.425017-1-l.wagner@proxmox.com>

gave this a quick spin on my PDM cluster and it seemed to work well.
Checked the available upgrades for all my nodes (PVE 8 and PVE 9). Then
upgraded a node and re-checked the output.


Some notes (all of them seem to be pre-existing to the current panel):

We might want to show a custom text if there are no upgrades available.

We might wanna think about improving the description column since in its
current form it shows a small part of the description truncated, which
isn't that useful imo. The title field might be better suited for
displaying in the table view?
Potentially add that double-clicking on a row opens a small window that
shows a detailed view with the information we get from the API already?


Since they're all pre-existing and probably better suited for a
follow-up, consider this series:

Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>


On 9/2/25 5:14 PM, Lukas Wagner wrote:
> This series adds a new 'Updates' tab for PVE remotes. The existing status
> overview is moved to a new 'Overview' tab, which is visible by default.
> 
> On the backend side, we add a couple new API endpoints, which simply pass
> through the request to the PVE nodes, no caching for now.
> 
>   GET /pve/remotes/{remote}/nodes/{node}/apt
>      Get list of updatable packages
>   GET /pve/remotes/{remote}/nodes/{node}/changelog
>      Get list of changelog of package
>   POST /pve/remotes/{remote}/nodes/{node}/apt
>      Update APT package database
> 
> In terms of permissions, these new API endpoints require RESOURCE_MODIFY privs on
>     /resource/{remote}/node/{node}/system 
> 
> This was the result of a short discussion in the development chat room.
> 
> The existing APT view component is a bit large for this panel, maybe we could
> hide the package description by default (but not too important for now).
> 
> Future work (some backend work already started, but can't finish before my
> vacation):
> 
>   - "Global Update" view that lists update status of all remote nodes
>   - Cache update status per node (absolutely necessary for the 'global' view),
>     with a task refreshing the update status every couple of hours
>   - Maybe send a notification about the global update availabilty (require notification
>     stack integration first)
>   - Add new API functions to pdm-client crate and CLI
>   - Allow package upgrade (requires web socket proxying, as far as I can see,
>     haven't really looked into it much)
> 
> 
> pve-manager:
> 
> Lukas Wagner (1):
>   api: apt: add JSON schema for 'list_updates' endpoint
> 
>  PVE/API2/APT.pm | 46 +++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 45 insertions(+), 1 deletion(-)
> 
> 
> proxmox-api-types:
> 
> Lukas Wagner (3):
>   Schema2Rust: fix handling of non-optional params
>   generate: add bindings for various APT functions
>   refresh bindings
> 
>  pve-api-types/generate.pl                  |   4 +
>  pve-api-types/generator-lib/Schema2Rust.pm |   9 +-
>  pve-api-types/src/generated/code.rs        |  58 ++++++++++-
>  pve-api-types/src/generated/types.rs       | 108 +++++++++++++++++++++
>  4 files changed, 175 insertions(+), 4 deletions(-)
> 
> 
> proxmox-yew-comp:
> 
> Lukas Wagner (2):
>   apt view: allow to set task_base_url
>   apt view: reload if base urls have changed
> 
>  src/apt_package_manager.rs | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> 
> proxmox-datacenter-manager:
> 
> Lukas Wagner (4):
>   server: add api for getting available updates/changelogs for remote
>     nodes
>   ui: pve: promote node.rs to dir-style module
>   ui: pve: move node overview to a new overview tab
>   ui: pve: node: add update tab
> 
>  server/src/api/pve/apt.rs                | 119 +++++++++++++++++++++++
>  server/src/api/pve/mod.rs                |   3 +-
>  server/src/api/pve/node.rs               |   1 +
>  server/src/lib.rs                        |   1 +
>  server/src/remote_updates.rs             |  96 ++++++++++++++++++
>  ui/src/pve/node/mod.rs                   | 103 ++++++++++++++++++++
>  ui/src/pve/{node.rs => node/overview.rs} |  31 +++---
>  7 files changed, 333 insertions(+), 21 deletions(-)
>  create mode 100644 server/src/api/pve/apt.rs
>  create mode 100644 server/src/remote_updates.rs
>  create mode 100644 ui/src/pve/node/mod.rs
>  rename ui/src/pve/{node.rs => node/overview.rs} (95%)
> 
> 
> Summary over all repositories:
>   13 files changed, 576 insertions(+), 26 deletions(-)
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-09-03 10:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 15:14 Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH manager 1/1] api: apt: add JSON schema for 'list_updates' endpoint Lukas Wagner
2025-09-03  8:25   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-api-types 1/3] Schema2Rust: fix handling of non-optional params Lukas Wagner
2025-09-03  8:57   ` [pdm-devel] applied: " Wolfgang Bumiller
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-api-types 2/3] generate: add bindings for various APT functions Lukas Wagner
2025-09-03  8:58   ` [pdm-devel] applied: " Wolfgang Bumiller
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-api-types 3/3] refresh bindings Lukas Wagner
2025-09-03  8:59   ` Wolfgang Bumiller
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-yew-comp 1/2] apt view: allow to set task_base_url Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-yew-comp 2/2] apt view: reload if base urls have changed Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/4] server: add api for getting available updates/changelogs for remote nodes Lukas Wagner
2025-09-03  8:42   ` Lukas Wagner
2025-09-03  9:02   ` Stefan Hanreich
2025-09-03  9:19     ` Stefan Hanreich
2025-09-03  9:23     ` Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/4] ui: pve: promote node.rs to dir-style module Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/4] ui: pve: move node overview to a new overview tab Lukas Wagner
2025-09-03  9:10   ` Stefan Hanreich
2025-09-03  9:48     ` Lukas Wagner
2025-09-03  9:52       ` Stefan Hanreich
2025-09-03  9:55         ` Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 4/4] ui: pve: node: add update tab Lukas Wagner
2025-09-03 10:20 ` Stefan Hanreich [this message]
2025-09-03 11:43 ` [pdm-devel] superseded: [PATCH manager/proxmox{-api-types, -yew-comp, -datacenter-manager} 00/10] PVE node update view Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3611b960-62d6-4583-83c9-557dd0fb16b7@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal