public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab
@ 2026-05-27  7:45 Hannes Laimer
  2026-05-27  7:51 ` Hannes Laimer
  2026-05-27  7:56 ` superseded: " Hannes Laimer
  0 siblings, 2 replies; 3+ messages in thread
From: Hannes Laimer @ 2026-05-27  7:45 UTC (permalink / raw)
  To: pdm-devel

We don't show the advanced checkbox, so having the filter in the
advanced section will always have it hidden. This prevents submitting
cause the filter is required for static ip configurations. The disks
form has the same scenario, "advanced filtering" required based on form
input.

Not having it in advanced also makes sense cause advanced usually
implies optionality, which this is very much not for static, and for
dhcp this filter is ignored by the installer.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index e6c1bd0..5897fe3 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -400,8 +400,8 @@ pub fn render_network_options_form(
                 .name("netif-name-pinning-enabled")
                 .default(config.netif_name_pinning_enabled),
         )
-        .with_advanced_spacer()
-        .with_advanced_field(
+        .with_spacer()
+        .with_large_field(
             tr!("Network Device Filters"),
             KeyValueList::new()
                 .value(
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab
  2026-05-27  7:45 [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab Hannes Laimer
@ 2026-05-27  7:51 ` Hannes Laimer
  2026-05-27  7:56 ` superseded: " Hannes Laimer
  1 sibling, 0 replies; 3+ messages in thread
From: Hannes Laimer @ 2026-05-27  7:51 UTC (permalink / raw)
  To: pdm-devel

On 2026-05-27 09:45, Hannes Laimer wrote:
> We don't show the advanced checkbox, so having the filter in the
> advanced section will always have it hidden. This prevents submitting
> cause the filter is required for static ip configurations. The disks
> form has the same scenario, "advanced filtering" required based on form
> input.
> 
> Not having it in advanced also makes sense cause advanced usually
> implies optionality, which this is very much not for static, and for
> dhcp this filter is ignored by the installer.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> index e6c1bd0..5897fe3 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> @@ -400,8 +400,8 @@ pub fn render_network_options_form(
>                  .name("netif-name-pinning-enabled")
>                  .default(config.netif_name_pinning_enabled),
>          )
> -        .with_advanced_spacer()
> -        .with_advanced_field(
> +        .with_spacer()
> +        .with_large_field(

this should just be `with_field` we only have one col in the network
tab, will send a v2, sorry for the noise

>              tr!("Network Device Filters"),
>              KeyValueList::new()
>                  .value(





^ permalink raw reply	[flat|nested] 3+ messages in thread

* superseded: [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab
  2026-05-27  7:45 [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab Hannes Laimer
  2026-05-27  7:51 ` Hannes Laimer
@ 2026-05-27  7:56 ` Hannes Laimer
  1 sibling, 0 replies; 3+ messages in thread
From: Hannes Laimer @ 2026-05-27  7:56 UTC (permalink / raw)
  To: pdm-devel

superseded-by:
https://lore.proxmox.com/pdm-devel/20260527075606.40696-1-h.laimer@proxmox.com/T/#u

On 2026-05-27 09:45, Hannes Laimer wrote:
> We don't show the advanced checkbox, so having the filter in the
> advanced section will always have it hidden. This prevents submitting
> cause the filter is required for static ip configurations. The disks
> form has the same scenario, "advanced filtering" required based on form
> input.
> 
> Not having it in advanced also makes sense cause advanced usually
> implies optionality, which this is very much not for static, and for
> dhcp this filter is ignored by the installer.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> index e6c1bd0..5897fe3 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> @@ -400,8 +400,8 @@ pub fn render_network_options_form(
>                  .name("netif-name-pinning-enabled")
>                  .default(config.netif_name_pinning_enabled),
>          )
> -        .with_advanced_spacer()
> -        .with_advanced_field(
> +        .with_spacer()
> +        .with_large_field(
>              tr!("Network Device Filters"),
>              KeyValueList::new()
>                  .value(





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-27  7:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-27  7:45 [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab Hannes Laimer
2026-05-27  7:51 ` Hannes Laimer
2026-05-27  7:56 ` superseded: " Hannes Laimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal