public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager 3/4] api: views: run API handlers in proxy process
Date: Fri, 10 Apr 2026 16:01:18 +0200	[thread overview]
Message-ID: <20260410140119.338714-4-l.wagner@proxmox.com> (raw)
In-Reply-To: <20260410140119.338714-1-l.wagner@proxmox.com>

The config is readable/writable by the unprivileged proxy user, so there
is no real reason why this needs to run in a privileged context.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 server/src/api/config/views.rs | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/server/src/api/config/views.rs b/server/src/api/config/views.rs
index 731f2a42..db68da5d 100644
--- a/server/src/api/config/views.rs
+++ b/server/src/api/config/views.rs
@@ -22,7 +22,6 @@ pub const ROUTER: Router = Router::new()
     .match_all("id", &VIEW_ROUTER);
 
 #[api(
-    protected: true,
     access: {
         permission: &Permission::Anybody,
         description: "Returns the views the user has access to.",
@@ -71,7 +70,6 @@ pub fn get_views(rpcenv: &mut dyn RpcEnvironment) -> Result<Vec<ViewConfig>, Err
 }
 
 #[api(
-    protected: true,
     input: {
         properties: {
             view: {
@@ -129,7 +127,6 @@ pub enum DeletableProperty {
 }
 
 #[api(
-    protected: true,
     input: {
         properties: {
             id: {
@@ -215,7 +212,6 @@ pub fn update_view(
 }
 
 #[api(
-    protected: true,
     input: {
         properties: {
             id: {
-- 
2.47.3





  parent reply	other threads:[~2026-04-10 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 14:01 [PATCH datacenter-manager 0/4] views: verify digest, schema improvements Lukas Wagner
2026-04-10 14:01 ` [PATCH datacenter-manager 1/4] api: views: return config digest when retrieving views Lukas Wagner
2026-04-10 14:01 ` [PATCH datacenter-manager 2/4] ui: views: submit config digest when updating a view Lukas Wagner
2026-04-10 14:01 ` Lukas Wagner [this message]
2026-04-10 14:01 ` [PATCH datacenter-manager 4/4] api: views: improve API schema definitions Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410140119.338714-4-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal