From: Christoph Heiss <c.heiss@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager v3 14/38] api-types, cli: use ReturnType::new() instead of constructing it manually
Date: Fri, 3 Apr 2026 18:53:46 +0200 [thread overview]
Message-ID: <20260403165437.2166551-15-c.heiss@proxmox.com> (raw)
In-Reply-To: <20260403165437.2166551-1-c.heiss@proxmox.com>
.. like everywhere else.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Changes v2 -> v3:
* new patch
cli/client/src/pbs.rs | 10 ++--------
cli/client/src/pve.rs | 15 +++------------
cli/client/src/remotes.rs | 5 +----
lib/pdm-api-types/src/lib.rs | 8 ++++----
4 files changed, 10 insertions(+), 28 deletions(-)
diff --git a/cli/client/src/pbs.rs b/cli/client/src/pbs.rs
index 9972824..c59e0be 100644
--- a/cli/client/src/pbs.rs
+++ b/cli/client/src/pbs.rs
@@ -239,10 +239,7 @@ async fn list_tasks(remote: String) -> Result<(), Error> {
format_and_print_result_full(
&mut serde_json::to_value(data)?,
- &ReturnType {
- optional: false,
- schema: &TASK_LIST_SCHEMA,
- },
+ &ReturnType::new(false, &TASK_LIST_SCHEMA),
&env().format_args.output_format.to_string(),
&proxmox_router::cli::default_table_format_options(),
);
@@ -266,10 +263,7 @@ async fn task_status(remote: String, upid: String) -> Result<(), Error> {
format_and_print_result_full(
&mut serde_json::to_value(data)?,
- &ReturnType {
- optional: false,
- schema: &pdm_api_types::pbs::TaskStatus::API_SCHEMA,
- },
+ &ReturnType::new(false, &pdm_api_types::pbs::TaskStatus::API_SCHEMA),
&env().format_args.output_format.to_string(),
&Default::default(),
);
diff --git a/cli/client/src/pve.rs b/cli/client/src/pve.rs
index 19bd098..3bbc399 100644
--- a/cli/client/src/pve.rs
+++ b/cli/client/src/pve.rs
@@ -238,10 +238,7 @@ async fn cluster_resources(
format_and_print_result_full(
&mut serde_json::to_value(data)?,
- &ReturnType {
- optional: false,
- schema: &CLUSTER_LIST_SCHEMA,
- },
+ &ReturnType::new(false, &CLUSTER_LIST_SCHEMA),
&env().format_args.output_format.to_string(),
&Default::default(),
);
@@ -1077,10 +1074,7 @@ async fn list_tasks(remote: String, node: Option<String>) -> Result<(), Error> {
format_and_print_result_full(
&mut serde_json::to_value(data)?,
- &ReturnType {
- optional: false,
- schema: &TASK_LIST_SCHEMA,
- },
+ &ReturnType::new(false, &TASK_LIST_SCHEMA),
&env().format_args.output_format.to_string(),
&proxmox_router::cli::default_table_format_options(),
);
@@ -1104,10 +1098,7 @@ async fn task_status(remote: String, upid: String) -> Result<(), Error> {
format_and_print_result_full(
&mut serde_json::to_value(data)?,
- &ReturnType {
- optional: false,
- schema: &pve_api_types::TaskStatus::API_SCHEMA,
- },
+ &ReturnType::new(false, &pve_api_types::TaskStatus::API_SCHEMA),
&env().format_args.output_format.to_string(),
&Default::default(),
);
diff --git a/cli/client/src/remotes.rs b/cli/client/src/remotes.rs
index e087809..693774f 100644
--- a/cli/client/src/remotes.rs
+++ b/cli/client/src/remotes.rs
@@ -142,10 +142,7 @@ async fn remote_version(id: String) -> Result<(), Error> {
let data = client()?.remote_version(&id).await?;
format_and_print_result_full(
&mut serde_json::to_value(data)?,
- &ReturnType {
- optional: false,
- schema: &pve_api_types::VersionResponse::API_SCHEMA,
- },
+ &ReturnType::new(false, &pve_api_types::VersionResponse::API_SCHEMA),
&env().format_args.output_format.to_string(),
&Default::default(),
);
diff --git a/lib/pdm-api-types/src/lib.rs b/lib/pdm-api-types/src/lib.rs
index fec3c8f..aea1b5d 100644
--- a/lib/pdm-api-types/src/lib.rs
+++ b/lib/pdm-api-types/src/lib.rs
@@ -322,10 +322,10 @@ pub struct TaskStatistics {
pub by_remote: HashMap<String, TaskCount>,
}
-pub const NODE_TASKS_LIST_TASKS_RETURN_TYPE: ReturnType = ReturnType {
- optional: false,
- schema: &ArraySchema::new("A list of tasks.", &TaskListItem::API_SCHEMA).schema(),
-};
+pub const NODE_TASKS_LIST_TASKS_RETURN_TYPE: ReturnType = ReturnType::new(
+ false,
+ &ArraySchema::new("A list of tasks.", &TaskListItem::API_SCHEMA).schema(),
+);
#[api]
#[derive(Deserialize, Serialize, Copy, Clone, PartialEq, Eq)]
--
2.53.0
next prev parent reply other threads:[~2026-04-03 16:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 16:53 [PATCH proxmox/yew-pwt/datacenter-manager/installer v3 00/38] add auto-installer integration Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 01/38] api-macro: allow $ in identifier name Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 02/38] schema: oneOf: allow single string variant Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 03/38] schema: implement UpdaterType for HashMap and BTreeMap Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 04/38] network-types: move `Fqdn` type from proxmox-installer-common Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 05/38] network-types: implement api type for Fqdn Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 06/38] network-types: add api wrapper type for std::net::IpAddr Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 07/38] network-types: cidr: implement generic `IpAddr::new` constructor Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 08/38] network-types: fqdn: implement standard library Error for Fqdn Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 09/38] node-status: make KernelVersionInformation Clone + PartialEq Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 10/38] installer-types: add common types used by the installer Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 11/38] installer-types: add types used by the auto-installer Christoph Heiss
2026-04-03 16:53 ` [PATCH proxmox v3 12/38] installer-types: implement api type for all externally-used types Christoph Heiss
2026-04-03 16:53 ` [PATCH yew-widget-toolkit v3 13/38] widget: kvlist: add widget for user-modifiable data tables Christoph Heiss
2026-04-03 16:53 ` Christoph Heiss [this message]
2026-04-03 16:53 ` [PATCH datacenter-manager v3 15/38] api-types: add api types for auto-installer integration Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 16/38] config: add auto-installer configuration module Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 17/38] acl: wire up new /system/auto-installation acl path Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 18/38] server: api: add auto-installer integration module Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 19/38] server: api: auto-installer: add access token management endpoints Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 20/38] client: add bindings for auto-installer endpoints Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 21/38] ui: auto-installer: add installations overview panel Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 22/38] ui: auto-installer: add prepared answer configuration panel Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 23/38] ui: auto-installer: add access token " Christoph Heiss
2026-04-03 16:53 ` [PATCH datacenter-manager v3 24/38] docs: add documentation for auto-installer integration Christoph Heiss
2026-04-03 16:53 ` [PATCH installer v3 25/38] install: iso env: use JSON boolean literals for product config Christoph Heiss
2026-04-03 16:53 ` [PATCH installer v3 26/38] common: http: allow passing custom headers to post() Christoph Heiss
2026-04-03 16:53 ` [PATCH installer v3 27/38] common: options: move regex construction out of loop Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 28/38] assistant: support adding an authorization token for HTTP-based answers Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 29/38] tree-wide: used moved `Fqdn` type to proxmox-network-types Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 30/38] tree-wide: use `Cidr` type from proxmox-network-types Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 31/38] tree-wide: switch to filesystem types from proxmox-installer-types Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 32/38] post-hook: switch to types in proxmox-installer-types Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 33/38] auto: sysinfo: switch to types from proxmox-installer-types Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 34/38] fetch-answer: " Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 35/38] fetch-answer: http: prefer json over toml for answer format Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 36/38] fetch-answer: send auto-installer HTTP authorization token if set Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 37/38] tree-wide: switch out `Answer` -> `AutoInstallerConfig` types Christoph Heiss
2026-04-03 16:54 ` [PATCH installer v3 38/38] auto: drop now-dead answer file definitions Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403165437.2166551-15-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox