From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager 2/3] ui: acl: list granular level permission paths for views
Date: Tue, 31 Mar 2026 11:57:29 +0200 [thread overview]
Message-ID: <20260331095730.75329-3-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260331095730.75329-1-s.shaji@proxmox.com>
Previously, users were unable to assign permissions to individual views.
Resolved this by loading the views list and extending permission paths
to include specific view routes.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
.../configuration/permission_path_selector.rs | 66 +++++++++++++++----
1 file changed, 52 insertions(+), 14 deletions(-)
diff --git a/ui/src/configuration/permission_path_selector.rs b/ui/src/configuration/permission_path_selector.rs
index 59bdabb..91d8072 100644
--- a/ui/src/configuration/permission_path_selector.rs
+++ b/ui/src/configuration/permission_path_selector.rs
@@ -1,12 +1,15 @@
use std::rc::Rc;
+use anyhow::Error;
use yew::html::IntoPropValue;
-use pwt::prelude::*;
use pwt::widget::form::Combobox;
+use pwt::{prelude::*, AsyncPool};
use pwt_macros::{builder, widget};
+use crate::pdm_client;
+
static PREDEFINED_PATHS: &[&str] = &[
"/",
"/access",
@@ -44,33 +47,68 @@ impl PermissionPathSelector {
}
}
-enum Msg {}
+enum Msg {
+ Prefetched(Vec<String>),
+ PrefetchFailed,
+}
struct PdmPermissionPathSelector {
items: Rc<Vec<AttrValue>>,
+ _async_pool: AsyncPool,
}
-impl PdmPermissionPathSelector {}
+impl PdmPermissionPathSelector {
+ async fn get_view_paths() -> Result<Vec<String>, Error> {
+ let views = pdm_client().list_views().await?;
+ let paths: Vec<String> = views
+ .iter()
+ .map(|cfg| format!("/view/{}", cfg.id))
+ .collect();
+ Ok(paths)
+ }
+
+ async fn get_paths() -> Result<Vec<String>, Error> {
+ let paths = Self::get_view_paths().await?;
+ Ok(paths)
+ }
+}
impl Component for PdmPermissionPathSelector {
type Message = Msg;
type Properties = PermissionPathSelector;
- fn create(_ctx: &Context<Self>) -> Self {
- // TODO: fetch resources & remotes from the backend to improve the pre-defined selection of
- // acl paths
+ fn create(ctx: &Context<Self>) -> Self {
+ let base_items: Vec<AttrValue> = PREDEFINED_PATHS
+ .iter()
+ .map(|i| AttrValue::from(*i))
+ .collect();
+
+ let link = ctx.link().clone();
+ let async_pool = AsyncPool::new();
+ async_pool.spawn(async move {
+ let paths = Self::get_paths().await;
+ match paths {
+ Ok(paths) => link.send_message(Msg::Prefetched(paths)),
+ Err(_) => link.send_message(Msg::PrefetchFailed),
+ }
+ });
+
Self {
- items: Rc::new(
- PREDEFINED_PATHS
- .iter()
- .map(|i| AttrValue::from(*i))
- .collect(),
- ),
+ items: Rc::new(base_items),
+ _async_pool: async_pool,
}
}
- fn update(&mut self, _ctx: &Context<Self>, _msg: Self::Message) -> bool {
- false
+ fn update(&mut self, _ctx: &Context<Self>, msg: Self::Message) -> bool {
+ match msg {
+ Msg::Prefetched(paths) => {
+ let items = Rc::make_mut(&mut self.items);
+ items.extend(paths.into_iter().map(AttrValue::from));
+ items.sort_by_key(|k| k.to_lowercase());
+ true
+ }
+ Msg::PrefetchFailed => false,
+ }
}
fn view(&self, ctx: &Context<Self>) -> Html {
--
2.47.3
next prev parent reply other threads:[~2026-03-31 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 9:57 [PATCH datacenter-manager 0/3] ui: acl: pre-populate permission path selector Shan Shaji
2026-03-31 9:57 ` [PATCH datacenter-manager 1/3] pdm-client: add `list_views` function to fetch views list Shan Shaji
2026-03-31 9:57 ` Shan Shaji [this message]
2026-03-31 9:57 ` [PATCH datacenter-manager 3/3] ui: acl: extend permission paths to allow specific remote access Shan Shaji
2026-03-31 10:06 ` [PATCH datacenter-manager 0/3] ui: acl: pre-populate permission path selector Shannon Sterz
2026-04-01 8:16 ` applied: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331095730.75329-3-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox