From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager v2 4/7] ui: widgets: rename PveRealmSelector to RemoteRealmSelector
Date: Tue, 24 Feb 2026 10:59:10 +0100 [thread overview]
Message-ID: <20260224095913.73320-5-l.wagner@proxmox.com> (raw)
In-Reply-To: <20260224095913.73320-1-l.wagner@proxmox.com>
As this component will be changed to be usable for both, PVE and PBS.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Shan Shaji <s.shaji@proxmox.com>
Tested-by: Shan Shaji <s.shaji@proxmox.com>
---
ui/src/remotes/wizard_page_info.rs | 4 ++--
ui/src/widget/mod.rs | 2 +-
ui/src/widget/remote_realm_selector.rs | 12 ++++++------
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/ui/src/remotes/wizard_page_info.rs b/ui/src/remotes/wizard_page_info.rs
index 4551212e..b3a000c3 100644
--- a/ui/src/remotes/wizard_page_info.rs
+++ b/ui/src/remotes/wizard_page_info.rs
@@ -23,7 +23,7 @@ use pdm_api_types::remotes::{NodeUrl, Remote, RemoteType, REMOTE_ID_SCHEMA};
use pwt_macros::builder;
use super::wizard_page_connect::ConnectParams;
-use crate::{get_nodename, widget::PveRealmSelector};
+use crate::{get_nodename, widget::RemoteRealmSelector};
#[derive(Clone, PartialEq, Properties)]
#[builder]
@@ -329,7 +329,7 @@ impl Component for PdmWizardPageInfo {
)
.with_field(
tr!("Realm"),
- PveRealmSelector::new(hostname, fingerprint)
+ RemoteRealmSelector::new(hostname, fingerprint)
.name("realm")
.disabled(!self.user_mode)
.required(self.user_mode),
diff --git a/ui/src/widget/mod.rs b/ui/src/widget/mod.rs
index e0aa029a..cd66756a 100644
--- a/ui/src/widget/mod.rs
+++ b/ui/src/widget/mod.rs
@@ -14,7 +14,7 @@ mod pve_migrate_mapping;
pub use pve_migrate_mapping::PveMigrateMap;
mod remote_realm_selector;
-pub use remote_realm_selector::PveRealmSelector;
+pub use remote_realm_selector::RemoteRealmSelector;
mod resource_tree;
pub use resource_tree::{RedrawController, ResourceTree};
diff --git a/ui/src/widget/remote_realm_selector.rs b/ui/src/widget/remote_realm_selector.rs
index bcf60a11..d484dc1c 100644
--- a/ui/src/widget/remote_realm_selector.rs
+++ b/ui/src/widget/remote_realm_selector.rs
@@ -16,10 +16,10 @@ use proxmox_yew_comp::percent_encoding::percent_encode_component;
use pwt::props::{FieldBuilder, WidgetBuilder};
use pwt_macros::{builder, widget};
-#[widget(comp=PdmPveRealmSelector, @input)]
+#[widget(comp=RemoteRealmSelectorComp, @input)]
#[derive(Clone, Properties, PartialEq)]
#[builder]
-pub struct PveRealmSelector {
+pub struct RemoteRealmSelector {
/// The default value.
#[builder(IntoPropValue, into_prop_value)]
#[prop_or_default]
@@ -30,7 +30,7 @@ pub struct PveRealmSelector {
pub fingerprint: Option<AttrValue>,
}
-impl PveRealmSelector {
+impl RemoteRealmSelector {
pub fn new(
hostname: impl IntoPropValue<AttrValue>,
fingerprint: impl IntoPropValue<Option<AttrValue>>,
@@ -42,15 +42,15 @@ impl PveRealmSelector {
}
}
-pub struct PdmPveRealmSelector {
+pub struct RemoteRealmSelectorComp {
store: Store<BasicRealmInfo>,
validate: ValidateFn<(String, Store<BasicRealmInfo>)>,
picker: RenderFn<SelectorRenderArgs<Store<BasicRealmInfo>>>,
}
-impl Component for PdmPveRealmSelector {
+impl Component for RemoteRealmSelectorComp {
type Message = ();
- type Properties = PveRealmSelector;
+ type Properties = RemoteRealmSelector;
fn create(ctx: &Context<Self>) -> Self {
let store = Store::new().on_change(ctx.link().callback(|_| ())); // trigger redraw
--
2.47.3
next prev parent reply other threads:[~2026-02-24 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 9:59 [PATCH datacenter-manager v2 0/7] fix #7192: properly enumerate PBS realms in 'Add Remote' wizard Lukas Wagner
2026-02-24 9:59 ` [PATCH datacenter-manager v2 1/7] pbs-client: add `list_domains` Lukas Wagner
2026-02-24 9:59 ` [PATCH datacenter-manager v2 2/7] api: pbs: add /pbs/realms endpoint Lukas Wagner
2026-02-24 9:59 ` [PATCH datacenter-manager v2 3/7] ui: rename pve_realm_selector module to remote_realm_selector Lukas Wagner
2026-02-24 9:59 ` Lukas Wagner [this message]
2026-02-24 9:59 ` [PATCH datacenter-manager v2 5/7] ui: widgets: make RemoteRealmSelectorComp private Lukas Wagner
2026-02-24 9:59 ` [PATCH datacenter-manager v2 6/7] ui: widget: remote realm selector: add missing docstrings Lukas Wagner
2026-02-24 9:59 ` [PATCH datacenter-manager v2 7/7] ui: widgets: remote realm selector: support PBS remotes Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224095913.73320-5-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox