From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager v4 1/6] server: pbs-client: add method to delete token from remote
Date: Wed, 18 Feb 2026 17:41:29 +0100 [thread overview]
Message-ID: <20260218164135.413762-2-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260218164135.413762-1-s.shaji@proxmox.com>
Inorder to allow deleting the generated token of PBS from PDM, add
method inside the `PbsClient` to delete the token.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
changes since v3:
- use percent_encoding to encode the userid.
- change the function name from delete_admin_token to delete_token.
- nit: change "API-Token" to "API token".
- pass &TokennameRef from callsite.
server/src/pbs_client.rs | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/server/src/pbs_client.rs b/server/src/pbs_client.rs
index f4f1f82..6158da7 100644
--- a/server/src/pbs_client.rs
+++ b/server/src/pbs_client.rs
@@ -13,7 +13,7 @@ use proxmox_router::stream::JsonRecords;
use proxmox_schema::api;
use proxmox_section_config::typed::SectionConfigData;
-use pbs_api_types::{Authid, Tokenname, Userid};
+use pbs_api_types::{Authid, Tokenname, TokennameRef, Userid};
use pdm_api_types::remotes::{Remote, RemoteType};
@@ -260,6 +260,20 @@ impl PbsClient {
Ok(token)
}
+ /// Delete API token from the PBS remote.
+ pub async fn delete_token(&self, userid: &Userid, tokenid: &TokennameRef) -> Result<(), Error> {
+ let path = format!(
+ "/api2/extjs/access/users/{}/token/{}",
+ percent_encoding::percent_encode(
+ userid.as_str().as_bytes(),
+ percent_encoding::NON_ALPHANUMERIC
+ ),
+ tokenid.as_str()
+ );
+ self.0.delete(&path).await?.nodata()?;
+ Ok(())
+ }
+
/// Return the status the Proxmox Backup Server instance
pub async fn node_status(&self) -> Result<pbs_api_types::NodeStatus, Error> {
let path = "/api2/extjs/nodes/localhost/status";
--
2.47.3
next prev parent reply other threads:[~2026-02-18 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 16:41 [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token Shan Shaji
2026-02-18 16:41 ` Shan Shaji [this message]
2026-02-18 16:41 ` [PATCH datacenter-manager v4 2/6] fix #6914: api: add support to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 3/6] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 4/6] fix #6914: cli-client: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 5/6] fix #6914: ui: add remove remote dialog with optional token deletion Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 6/6] fix #6914: cli-admin: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH proxmox v4 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218164135.413762-2-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox