public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager v3 6/6] cli: admin: add `delete-token` option to delete token from remote
Date: Wed, 11 Feb 2026 16:20:15 +0100	[thread overview]
Message-ID: <20260211152016.445817-7-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260211152016.445817-1-s.shaji@proxmox.com>

Inorder to allow deleting the remote API token from PDM, added optional
boolean flag.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---

 **note**: No changes since v2. This was not included in v1.  

 cli/admin/src/remotes.rs | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/cli/admin/src/remotes.rs b/cli/admin/src/remotes.rs
index edd3fd8..6702667 100644
--- a/cli/admin/src/remotes.rs
+++ b/cli/admin/src/remotes.rs
@@ -217,16 +217,28 @@ fn update_remote(
     input: {
         properties: {
             id: { schema: REMOTE_ID_SCHEMA },
+            "delete-token": {
+                type: bool,
+                optional: true,
+                description: "Remove the API-Token from remote."
+            }
         }
     }
 )]
-/// Add a new remote.
-fn remove_remote(id: String, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
-    let param = json!({ "id": id });
+/// Remove a new remote.
+async fn remove_remote(
+    id: String,
+    delete_token: Option<bool>,
+    rpcenv: &mut dyn RpcEnvironment,
+) -> Result<(), Error> {
+    let mut param = json!({ "id": id });
+    if delete_token.is_some() {
+        param["delete-token"] = delete_token.into();
+    }
 
     let info = &dc_api::remotes::API_METHOD_REMOVE_REMOTE;
     match info.handler {
-        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv).map(drop),
+        ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await.map(drop),
         _ => unreachable!(),
     }
 }
-- 
2.47.3





  parent reply	other threads:[~2026-02-11 15:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 15:20 [PATCH datacenter-manager/proxmox v3 0/7] fix #6914: add option to remove already existing token Shan Shaji
2026-02-11 15:20 ` [PATCH datacenter-manager v3 1/6] server: pbs-client: add delete admin token method Shan Shaji
2026-02-13 13:20   ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 2/6] server: api: add support to optionally delete token from remote Shan Shaji
2026-02-13 13:20   ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 3/6] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2026-02-13 13:20   ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 4/6] cli: client: add `delete-token` option to delete token from remote Shan Shaji
2026-02-13 13:21   ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 5/6] fix: ui: add remove confirmation dialog with optional token deletion Shan Shaji
2026-02-13 13:21   ` Lukas Wagner
2026-02-11 15:20 ` Shan Shaji [this message]
2026-02-13 13:21   ` [PATCH datacenter-manager v3 6/6] cli: admin: add `delete-token` option to delete token from remote Lukas Wagner
2026-02-11 15:20 ` [PATCH proxmox v3 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
2026-02-13 13:19 ` [PATCH datacenter-manager/proxmox v3 0/7] fix #6914: add option to remove already existing token Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211152016.445817-7-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal