public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager v4 6/6] clippy: remote tasks: remove unneeded enclosing Ok(...) and ?
Date: Fri,  6 Feb 2026 14:44:33 +0100	[thread overview]
Message-ID: <20260206134433.311230-9-l.wagner@proxmox.com> (raw)
In-Reply-To: <20260206134433.311230-1-l.wagner@proxmox.com>

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 server/src/remote_tasks/refresh_task.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/remote_tasks/refresh_task.rs b/server/src/remote_tasks/refresh_task.rs
index 49cdd112..92716a10 100644
--- a/server/src/remote_tasks/refresh_task.rs
+++ b/server/src/remote_tasks/refresh_task.rs
@@ -377,7 +377,7 @@ async fn apply_journal(cache: TaskCache) -> Result<(), Error> {
 
 /// Get a list of active tasks.
 async fn get_active_tasks(cache: TaskCache) -> Result<Vec<RemoteUpid>, Error> {
-    Ok(tokio::task::spawn_blocking(move || {
+    tokio::task::spawn_blocking(move || {
         let tasks: Vec<RemoteUpid> = cache
             .read()?
             .get_tasks(GetTasks::Active)?
@@ -386,7 +386,7 @@ async fn get_active_tasks(cache: TaskCache) -> Result<Vec<RemoteUpid>, Error> {
 
         Ok::<Vec<RemoteUpid>, Error>(tasks)
     })
-    .await??)
+    .await?
 }
 
 #[derive(PartialEq, Debug)]
-- 
2.47.3





      parent reply	other threads:[~2026-02-06 13:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 13:44 [PATCH datacenter-manager/proxmox-yew-comp v4 0/8] manual refresh button for remote task cache Lukas Wagner
2026-02-06 13:44 ` [PATCH proxmox-yew-comp v4 1/2] task list: add support for starting refresh tasks Lukas Wagner
2026-02-06 13:44 ` [PATCH proxmox-yew-comp v4 2/2] loadable component: don't trigger reload when starting a task Lukas Wagner
2026-02-06 13:44 ` [PATCH datacenter-manager v4 1/6] remote tasks: move implementation to server crate Lukas Wagner
2026-02-06 13:44 ` [PATCH datacenter-manager v4 2/6] remote tasks: implement `refresh_task_cache` for manual task fetching Lukas Wagner
2026-02-06 13:44 ` [PATCH datacenter-manager v4 3/6] api: add /remotes/tasks/refresh Lukas Wagner
2026-02-06 13:44 ` [PATCH datacenter-manager v4 4/6] ui: remote task view: set refresh_task_url property for task viewer Lukas Wagner
2026-02-06 13:44 ` [PATCH datacenter-manager v4 5/6] clippy: remote tasks: implement Default for TaskState Lukas Wagner
2026-02-06 13:44 ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260206134433.311230-9-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal