public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-backup 1/1] refactor: log: replace use of `tasklog_pbs` with `tasklog`
Date: Wed, 28 Jan 2026 14:54:57 +0100	[thread overview]
Message-ID: <20260128135457.245662-4-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260128135457.245662-1-s.shaji@proxmox.com>

The `tasklog_pbs` function was used on both PBS and PDM. Since the
function was not specific to PBS anymore, the same has been deprecated
and added a new `tasklog` function inside the proxmox-log crate.
To avoid deprecation warning replaced all call sites of
`tasklog_pbs` with `tasklog` function.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 src/bin/proxmox-backup-api.rs     | 2 +-
 src/bin/proxmox-backup-manager.rs | 2 +-
 src/bin/proxmox-backup-proxy.rs   | 2 +-
 src/bin/proxmox-daily-update.rs   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/bin/proxmox-backup-api.rs b/src/bin/proxmox-backup-api.rs
index 417e9e97..922fc77e 100644
--- a/src/bin/proxmox-backup-api.rs
+++ b/src/bin/proxmox-backup-api.rs
@@ -44,7 +44,7 @@ fn get_index() -> Pin<Box<dyn Future<Output = Response<Body>> + Send>> {
 async fn run() -> Result<(), Error> {
     proxmox_log::Logger::from_env("PBS_LOG", LevelFilter::INFO)
         .journald_on_no_workertask()
-        .tasklog_pbs()
+        .tasklog()
         .init()?;
 
     config::create_configdir()?;
diff --git a/src/bin/proxmox-backup-manager.rs b/src/bin/proxmox-backup-manager.rs
index f8365070..b2f09170 100644
--- a/src/bin/proxmox-backup-manager.rs
+++ b/src/bin/proxmox-backup-manager.rs
@@ -663,7 +663,7 @@ async fn run() -> Result<(), Error> {
     // will directly execute workertasks.
     proxmox_log::Logger::from_env("PBS_LOG", proxmox_log::LevelFilter::INFO)
         .stderr_on_no_workertask()
-        .tasklog_pbs()
+        .tasklog()
         .init()?;
     proxmox_backup::server::notifications::init()?;
     proxmox_product_config::init(pbs_config::backup_user()?, pbs_config::priv_user()?);
diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs
index 870208fe..482f3a1a 100644
--- a/src/bin/proxmox-backup-proxy.rs
+++ b/src/bin/proxmox-backup-proxy.rs
@@ -181,7 +181,7 @@ async fn get_index_future(env: RestEnvironment, parts: Parts) -> Response<Body>
 async fn run() -> Result<(), Error> {
     proxmox_log::Logger::from_env("PBS_LOG", LevelFilter::INFO)
         .journald_on_no_workertask()
-        .tasklog_pbs()
+        .tasklog()
         .init()?;
 
     proxmox_backup::auth_helpers::setup_auth_context(false);
diff --git a/src/bin/proxmox-daily-update.rs b/src/bin/proxmox-daily-update.rs
index 224103cc..8b82c6c6 100644
--- a/src/bin/proxmox-daily-update.rs
+++ b/src/bin/proxmox-daily-update.rs
@@ -113,7 +113,7 @@ fn main() {
     // We need to use the tasklog layer here because we call a workertask.
     proxmox_log::Logger::from_env("PBS_LOG", proxmox_log::LevelFilter::INFO)
         .journald_on_no_workertask()
-        .tasklog_pbs()
+        .tasklog()
         .init()
         .expect("unable to initialize logger");
 
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      parent reply	other threads:[~2026-01-28 13:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 13:54 [pdm-devel] [PATCH datacenter-manager/proxmox{, -backup} 0/3] refactor: log: deprecate tasklog_pbs and replace its usages with tasklog Shan Shaji
2026-01-28 13:54 ` [pdm-devel] [PATCH proxmox 1/1] proxmox-log: deprecate `tasklog_pbs` and add `tasklog` function Shan Shaji
2026-01-28 13:54 ` [pdm-devel] [PATCH datacenter-manager 1/1] refactor: log: replace use of `tasklog_pbs` with `tasklog` Shan Shaji
2026-01-28 13:54 ` Shan Shaji [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128135457.245662-4-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal