From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 1/7] remove needless borrows
Date: Mon, 29 Dec 2025 17:18:36 +0100 [thread overview]
Message-ID: <20251229161844.49433-2-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20251229161844.49433-1-m.sandoval@proxmox.com>
Detected by clippy.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
cli/client/src/subscriptions.rs | 2 +-
server/src/api/nodes/sdn.rs | 2 +-
server/src/api/remote_shell.rs | 4 ++--
server/src/api/resources.rs | 2 +-
server/src/auth/mod.rs | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/cli/client/src/subscriptions.rs b/cli/client/src/subscriptions.rs
index bf450a5f..d8bf1e09 100644
--- a/cli/client/src/subscriptions.rs
+++ b/cli/client/src/subscriptions.rs
@@ -87,7 +87,7 @@ async fn get_subscription_status(
let mut node_status = node_status.iter().collect::<Vec<_>>();
- node_status.sort_by(|a, b| a.0.cmp(&b.0));
+ node_status.sort_by(|a, b| a.0.cmp(b.0));
for (node, info) in node_status {
let Some(info) = info else {
println!(" {node}");
diff --git a/server/src/api/nodes/sdn.rs b/server/src/api/nodes/sdn.rs
index 065ebe07..af5b7536 100644
--- a/server/src/api/nodes/sdn.rs
+++ b/server/src/api/nodes/sdn.rs
@@ -80,7 +80,7 @@ mod vnets {
) -> Result<Vec<SdnVnetMacVrf>, Error> {
let (remote_config, _) = pdm_config::remotes::config()?;
let remote = get_remote(&remote_config, &remote)?;
- let client = connect(&remote)?;
+ let client = connect(remote)?;
client
.get_vnet_mac_vrf(&node, &vnet)
diff --git a/server/src/api/remote_shell.rs b/server/src/api/remote_shell.rs
index c617b4dc..9a1dc183 100644
--- a/server/src/api/remote_shell.rs
+++ b/server/src/api/remote_shell.rs
@@ -171,7 +171,7 @@ fn upgrade_to_websocket(
let remote = get_remote(&remotes, &remote)?;
let (ticket, port) = match remote.ty {
RemoteType::Pve => {
- let pve = crate::connection::make_pve_client(&remote)?;
+ let pve = crate::connection::make_pve_client(remote)?;
let pve_term_ticket = pve
.node_shell_termproxy(
&node,
@@ -184,7 +184,7 @@ fn upgrade_to_websocket(
(pve_term_ticket.ticket, pve_term_ticket.port)
}
RemoteType::Pbs => {
- let pbs = crate::connection::make_pbs_client(&remote)?;
+ let pbs = crate::connection::make_pbs_client(remote)?;
let pbs_term_ticket = pbs.node_shell_termproxy().await?;
(pbs_term_ticket.ticket, pbs_term_ticket.port as i64)
}
diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index c97644ad..ecccb94a 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -139,7 +139,7 @@ fn resource_matches_search_term(
MatchCategory::RemoteType => return None,
MatchCategory::NetworkType => match resource {
Resource::PveNetwork(network_resource) => {
- category.matches(&network_resource.network_type().as_str(), &term.value)
+ category.matches(network_resource.network_type().as_str(), &term.value)
}
_ => false,
},
diff --git a/server/src/auth/mod.rs b/server/src/auth/mod.rs
index 0d6bcddc..82425e8c 100644
--- a/server/src/auth/mod.rs
+++ b/server/src/auth/mod.rs
@@ -167,7 +167,7 @@ impl proxmox_auth_api::api::AuthContext for PdmAuthContext {
path_vec.push(part);
}
}
- user_info.check_privs(&auth_id, &path_vec, *privilege, false)?;
+ user_info.check_privs(auth_id, &path_vec, *privilege, false)?;
return Ok(Some(true));
}
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-29 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 16:18 [pdm-devel] [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90 Maximiliano Sandoval
2025-12-29 16:18 ` Maximiliano Sandoval [this message]
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/7] simplify if-else block Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/7] remote tasks: remove unneeded enclosing Ok() and ? Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 4/7] firewall: prefer is_some_and over map_or false Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 5/7] subscription: remove unneeded return statement Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 6/7] api: resources: collapse identical if blocks Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 7/7] api: resources: rewrite let-else block with ? Maximiliano Sandoval
2025-12-30 9:18 ` [pdm-devel] partially-applied: [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90 Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251229161844.49433-2-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox