From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90
Date: Mon, 29 Dec 2025 17:18:35 +0100 [thread overview]
Message-ID: <20251229161844.49433-1-m.sandoval@proxmox.com> (raw)
This was spotted with clippy 0.1.90 and rustc 1.90.
After this, there is only one renaming clippy lint after running Clippy, namely:
```
$ cargo clippy --all-targets --workspace --all-features
warning: this function has too many arguments (8/7)
--> lib/pdm-client/src/lib.rs:1093:5
|
1093 | / pub async fn pve_list_storages(
1094 | | &self,
1095 | | remote: &str,
1096 | | node: &str,
... |
1101 | | target: Option<String>,
1102 | | ) -> Result<Vec<StorageInfo>, Error> {
| |________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
warning: `pdm-client` (lib) generated 1 warning
warning: `pdm-client` (lib test) generated 1 warning (1 duplicate)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
```
Maximiliano Sandoval (7):
remove needless borrows
simplify if-else block
remote tasks: remove unneeded enclosing Ok() and ?
firewall: prefer is_some_and over map_or false
subscription: remove unneeded return statement
api: resources: collapse identical if blocks
api: resources: rewrite let-else block with ?
cli/admin/src/remotes.rs | 2 +-
cli/client/src/subscriptions.rs | 2 +-
server/src/api/nodes/sdn.rs | 2 +-
server/src/api/nodes/subscription.rs | 2 +-
server/src/api/pve/firewall.rs | 2 +-
server/src/api/remote_shell.rs | 4 +--
server/src/api/resources.rs | 29 +++++++++----------
server/src/auth/mod.rs | 2 +-
.../tasks/remote_tasks.rs | 4 +--
9 files changed, 23 insertions(+), 26 deletions(-)
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-12-29 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 16:18 Maximiliano Sandoval [this message]
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/7] remove needless borrows Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/7] simplify if-else block Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/7] remote tasks: remove unneeded enclosing Ok() and ? Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 4/7] firewall: prefer is_some_and over map_or false Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 5/7] subscription: remove unneeded return statement Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 6/7] api: resources: collapse identical if blocks Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 7/7] api: resources: rewrite let-else block with ? Maximiliano Sandoval
2025-12-30 9:18 ` [pdm-devel] partially-applied: [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90 Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251229161844.49433-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox