* [pdm-devel] [PATCH proxmox-yew-comp v2] task description: use hyphen (-) between the id and the action
@ 2025-12-19 12:40 Lukas Wagner
2025-12-19 12:51 ` [pdm-devel] applied: " Fabian Grünbichler
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2025-12-19 12:40 UTC (permalink / raw)
To: pdm-devel
This way it matches the way we render task descriptions in the JS code.
For instance, PBS GC tasks are now rendered as
"Datastore store2 - Garbage Collect"
instead of
"Datastore store2 Garbage Collect"
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
Changes since v1:
- rebased to latest master
src/utils/task_descriptions.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/utils/task_descriptions.rs b/src/utils/task_descriptions.rs
index 0184edf..09156ed 100644
--- a/src/utils/task_descriptions.rs
+++ b/src/utils/task_descriptions.rs
@@ -32,7 +32,7 @@ impl<A: Display, B: Display> IntoTaskDescriptionRenderFn for (A, B) {
let action = self.1.to_string();
Box::new(move |_, id| {
format!(
- "{} {} {}",
+ "{} {} - {}",
task_type,
id.as_deref().unwrap_or("unknown"),
action
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pdm-devel] applied: [PATCH proxmox-yew-comp v2] task description: use hyphen (-) between the id and the action
2025-12-19 12:40 [pdm-devel] [PATCH proxmox-yew-comp v2] task description: use hyphen (-) between the id and the action Lukas Wagner
@ 2025-12-19 12:51 ` Fabian Grünbichler
0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2025-12-19 12:51 UTC (permalink / raw)
To: pdm-devel, Lukas Wagner
On Fri, 19 Dec 2025 13:40:31 +0100, Lukas Wagner wrote:
> This way it matches the way we render task descriptions in the JS code.
> For instance, PBS GC tasks are now rendered as
>
> "Datastore store2 - Garbage Collect"
>
> instead of
>
> [...]
Applied, thanks!
[1/1] task description: use hyphen (-) between the id and the action
commit: 8b32c15ad82c5290fdd3fdb15e3fce6fdbfd3a63
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-19 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-19 12:40 [pdm-devel] [PATCH proxmox-yew-comp v2] task description: use hyphen (-) between the id and the action Lukas Wagner
2025-12-19 12:51 ` [pdm-devel] applied: " Fabian Grünbichler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox