From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-yew-comp v2 2/2] loadable component: don't trigger reload when starting a task
Date: Thu, 18 Dec 2025 15:20:03 +0100 [thread overview]
Message-ID: <20251218142007.279631-3-l.wagner@proxmox.com> (raw)
In-Reply-To: <20251218142007.279631-1-l.wagner@proxmox.com>
The view will be reloaded anyways when the task viewer closes.
Usually, one wants to start a new task to produce/refresh some data
which should later be displayed in the component, so it makes little
sense to reload before the task actually finishes.
This avoids an issue with the previous commit. The double-load would
reset 'fresh_load' after the first load, leading to the new data not
being correctly displayed after the second load.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/loadable_component.rs | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/loadable_component.rs b/src/loadable_component.rs
index 389ae28..7e26b24 100644
--- a/src/loadable_component.rs
+++ b/src/loadable_component.rs
@@ -333,7 +333,6 @@ impl<M, V: PartialEq, T: 'static + LoadableComponent<Message = M, ViewState = V>
self.send_message(Msg::Spawn(Box::pin(async move {
match command_future.await {
Ok(task_id) => {
- link.send_reload();
if short {
link.show_task_progres(task_id);
} else {
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-18 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 14:20 [pdm-devel] [PATCH datacenter-manager/proxmox-yew-comp v2 0/6] manual refresh button for remote task cache Lukas Wagner
2025-12-18 14:20 ` [pdm-devel] [PATCH proxmox-yew-comp v2 1/2] task list: add support for starting refresh tasks Lukas Wagner
2025-12-18 14:20 ` Lukas Wagner [this message]
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 1/4] remote tasks: move implementation to server crate Lukas Wagner
2025-12-19 13:50 ` Shannon Sterz
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 2/4] remote tasks: implement `refresh_task_cache` for manual task fetching Lukas Wagner
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 3/4] api: add /remotes/tasks/refresh Lukas Wagner
2025-12-19 13:52 ` Shannon Sterz
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 4/4] ui: remote task view: set refresh_task_url property for task viewer Lukas Wagner
2025-12-19 13:53 ` [pdm-devel] [PATCH datacenter-manager/proxmox-yew-comp v2 0/6] manual refresh button for remote task cache Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218142007.279631-3-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox