public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH datacenter-manager] ui: resource tree: name all columns and make them translatable
@ 2025-12-16 15:52 Shannon Sterz
  0 siblings, 0 replies; only message in thread
From: Shannon Sterz @ 2025-12-16 15:52 UTC (permalink / raw)
  To: pdm-devel

not giving a column a name leads to bad UX when editing the currently
visible columns of a table. the menu will then render a checkbox with
an empty label which may appear confusing.

additionally, make all column headers of the table translatable.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 ui/src/widget/resource_tree.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/src/widget/resource_tree.rs b/ui/src/widget/resource_tree.rs
index c7d6e67..ba178b8 100644
--- a/ui/src/widget/resource_tree.rs
+++ b/ui/src/widget/resource_tree.rs
@@ -414,7 +414,7 @@ fn columns(
                     .into()
             })
             .into(),
-        DataTableColumn::new("Node")
+        DataTableColumn::new(tr!("Node"))
             .width("150px")
             .render(|item: &PdmTreeEntry| {
                 match item {
@@ -427,7 +427,7 @@ fn columns(
                 .into()
             })
             .into(),
-        DataTableColumn::new("")
+        DataTableColumn::new(tr!("UI"))
             .width("50px")
             .justify("right")
             .render({
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-12-16 15:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-16 15:52 [pdm-devel] [PATCH datacenter-manager] ui: resource tree: name all columns and make them translatable Shannon Sterz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal