public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp] wizard: prevent page reload when pressing enter in form
Date: Thu, 11 Dec 2025 14:32:15 +0100	[thread overview]
Message-ID: <20251211133223.2607590-1-d.csapak@proxmox.com> (raw)

When pressing enter while the focus is inside a `Form` element, the
browser tries to submit the form, and the default method is to send the
data to the page via GET parameters.

This can lead to unwanted refreshes, e.g. in PDM the remote wizard would
change the url from
 https://<hostname>:8443/#/
to
 https://<hostname>:8443/?#/

which refreshed the page.

To prevent that, use `event.prevent_default()` in the onsubmit handler,
since we handle submitting the data ourselves there.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/wizard.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/wizard.rs b/src/wizard.rs
index 802a816..7d83da1 100644
--- a/src/wizard.rs
+++ b/src/wizard.rs
@@ -524,7 +524,8 @@ impl Component for PwtWizard {
                 .form_context(form_ctx.clone())
                 .onsubmit(ctx.link().batch_callback({
                     let state = self.controller.clone();
-                    move |_| {
+                    move |event: SubmitEvent| {
+                        event.prevent_default(); // don't reload the page
                         if !state.read().can_progress() {
                             return None;
                         }
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


                 reply	other threads:[~2025-12-11 13:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251211133223.2607590-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal