From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 3/5] ui: configuration: subscription: improve behavior on 'check'
Date: Thu, 4 Dec 2025 15:20:27 +0100 [thread overview]
Message-ID: <20251204142451.2992215-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251204142451.2992215-1-d.csapak@proxmox.com>
Since the subscription check/load can take a bit, disable the 'check'
button during a check operation and let the refresh button indicate a
load.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/configuration/subscription_panel.rs | 42 +++++++++++-----------
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/ui/src/configuration/subscription_panel.rs b/ui/src/configuration/subscription_panel.rs
index 8f3a4b9d..b2d50957 100644
--- a/ui/src/configuration/subscription_panel.rs
+++ b/ui/src/configuration/subscription_panel.rs
@@ -26,6 +26,7 @@ impl SubscriptionPanel {
}
pub enum Msg {
+ Checking,
LoadFinished(Value),
}
@@ -33,6 +34,7 @@ pub struct ProxmoxSubscriptionPanel {
rows: Rc<Vec<KVGridRow>>,
data: Option<Rc<Value>>,
loaded: bool,
+ checking: bool,
}
impl LoadableComponent for ProxmoxSubscriptionPanel {
@@ -45,14 +47,29 @@ impl LoadableComponent for ProxmoxSubscriptionPanel {
rows: Rc::new(rows()),
data: None,
loaded: false,
+ checking: false,
}
}
- fn update(&mut self, _ctx: &LoadableComponentContext<Self>, msg: Self::Message) -> bool {
+ fn update(&mut self, ctx: &LoadableComponentContext<Self>, msg: Self::Message) -> bool {
match msg {
Msg::LoadFinished(value) => {
self.data = Some(Rc::new(value));
self.loaded = true;
+ self.checking = false;
+ }
+ Msg::Checking => {
+ self.checking = true;
+ let link = ctx.link();
+ link.spawn({
+ let link = link.clone();
+ async move {
+ match http_post(SUBSCRIPTION_URL, None).await {
+ Ok(()) => link.send_reload(),
+ Err(err) => link.show_error(tr!("Error"), err.to_string(), true),
+ }
+ }
+ });
}
}
true
@@ -71,36 +88,21 @@ impl LoadableComponent for ProxmoxSubscriptionPanel {
}
fn toolbar(&self, ctx: &LoadableComponentContext<Self>) -> Option<Html> {
+ let link = ctx.link();
let toolbar = Toolbar::new()
.class("pwt-overflow-hidden")
.border_bottom(true)
.with_child(
Button::new(tr!("Check"))
+ .disabled(self.checking)
.icon_class("fa fa-check-square-o")
- .on_activate({
- let link = ctx.link();
-
- move |_| {
- link.spawn({
- let link = link.clone();
- async move {
- match http_post(SUBSCRIPTION_URL, None).await {
- Ok(()) => link.send_reload(),
- Err(err) => {
- link.show_error(tr!("Error"), err.to_string(), true)
- }
- }
- }
- })
- }
- }),
+ .on_activate(link.callback(|_| Msg::Checking)),
)
.with_spacer()
.with_flex_spacer()
.with_child({
let loading = ctx.loading();
- let link = ctx.link();
- Button::refresh(loading).on_activate(move |_| link.send_reload())
+ Button::refresh(loading || self.checking).on_activate(move |_| link.send_reload())
});
Some(toolbar.into())
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-04 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 14:20 [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 1/5] ui: pve: remove overview: allow line-breaks for long lines Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 2/5] ui: remote updates: show progress on 'refresh all' Dominik Csapak
2025-12-04 14:20 ` Dominik Csapak [this message]
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 4/5] ui: views: add message on empty layouts Dominik Csapak
2025-12-04 15:18 ` Lukas Wagner
2025-12-04 14:20 ` [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes Dominik Csapak
2025-12-04 15:21 ` Lukas Wagner
2025-12-04 20:01 ` Thomas Lamprecht
2025-12-05 7:35 ` Dominik Csapak
2025-12-04 15:23 ` [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Lukas Wagner
2025-12-04 20:01 ` [pdm-devel] partially-applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204142451.2992215-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox