From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 2/5] ui: remote updates: show progress on 'refresh all'
Date: Thu, 4 Dec 2025 15:20:26 +0100 [thread overview]
Message-ID: <20251204142451.2992215-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251204142451.2992215-1-d.csapak@proxmox.com>
The subscription check can take a bit, so show a loading bar and disable
the refresh button while that is loading.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/remotes/updates.rs | 35 ++++++++++++++++++++++++++++-------
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/ui/src/remotes/updates.rs b/ui/src/remotes/updates.rs
index 12eaec87..418aad98 100644
--- a/ui/src/remotes/updates.rs
+++ b/ui/src/remotes/updates.rs
@@ -22,7 +22,7 @@ use proxmox_yew_comp::{
LoadableComponentContext, LoadableComponentMaster,
};
use pwt::props::{CssBorderBuilder, CssPaddingBuilder, WidgetStyleBuilder};
-use pwt::widget::{Button, Container, Panel, Tooltip};
+use pwt::widget::{Button, Container, Panel, Progress, Tooltip};
use pwt::{
css,
css::FontColor,
@@ -123,6 +123,7 @@ enum RemoteUpdateTreeMsg {
LoadFinished(UpdateSummary),
KeySelected(Option<Key>),
RefreshAll,
+ RefreshFinished,
CheckSubscription,
}
@@ -130,6 +131,7 @@ struct UpdateTreeComponent {
store: TreeStore<UpdateTreeEntry>,
selection: Selection,
selected_entry: Option<UpdateTreeEntry>,
+ refreshing: bool,
}
fn default_sorter(a: &UpdateTreeEntry, b: &UpdateTreeEntry) -> Ordering {
@@ -333,6 +335,7 @@ impl LoadableComponent for UpdateTreeComponent {
store: store.clone(),
selection,
selected_entry: None,
+ refreshing: false,
}
}
@@ -378,6 +381,10 @@ impl LoadableComponent for UpdateTreeComponent {
return true;
}
+ Self::Message::RefreshFinished => {
+ self.refreshing = false;
+ return true;
+ }
Self::Message::KeySelected(key) => {
if let Some(key) = key {
let read_guard = self.store.read();
@@ -392,6 +399,7 @@ impl LoadableComponent for UpdateTreeComponent {
Self::Message::CheckSubscription => {
let link = ctx.link();
+ self.refreshing = true;
link.clone().spawn(async move {
// Use the PDM subscription check for the global refresh all.
let is_active = check_pdm_subscription().await;
@@ -400,6 +408,7 @@ impl LoadableComponent for UpdateTreeComponent {
} else {
link.send_message(RemoteUpdateTreeMsg::RefreshAll);
}
+ link.send_message(RemoteUpdateTreeMsg::RefreshFinished);
});
}
Self::Message::RefreshAll => {
@@ -443,12 +452,14 @@ impl UpdateTreeComponent {
.show_header(true)
.class(css::FlexFit);
- let refresh_all_button = Button::new(tr!("Refresh all")).on_activate({
- let link = ctx.link().clone();
- move |_| {
- link.send_message(RemoteUpdateTreeMsg::CheckSubscription);
- }
- });
+ let refresh_all_button = Button::new(tr!("Refresh all"))
+ .disabled(self.refreshing)
+ .on_activate({
+ let link = ctx.link().clone();
+ move |_| {
+ link.send_message(RemoteUpdateTreeMsg::CheckSubscription);
+ }
+ });
let title: Html = Row::new()
.gap(2)
@@ -466,6 +477,16 @@ impl UpdateTreeComponent {
.style("flex", "1 1 0")
.class(FlexFit)
.border(true)
+ .with_optional_child(
+ self.refreshing.then_some(
+ Container::new().style("position", "relative").with_child(
+ Progress::new()
+ .style("position", "absolute")
+ .style("left", "0")
+ .style("right", "0"),
+ ),
+ ),
+ )
.with_child(table)
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-04 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 14:20 [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 1/5] ui: pve: remove overview: allow line-breaks for long lines Dominik Csapak
2025-12-04 14:20 ` Dominik Csapak [this message]
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 3/5] ui: configuration: subscription: improve behavior on 'check' Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 4/5] ui: views: add message on empty layouts Dominik Csapak
2025-12-04 15:18 ` Lukas Wagner
2025-12-04 14:20 ` [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes Dominik Csapak
2025-12-04 15:21 ` Lukas Wagner
2025-12-04 20:01 ` Thomas Lamprecht
2025-12-05 7:35 ` Dominik Csapak
2025-12-04 15:23 ` [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Lukas Wagner
2025-12-04 20:01 ` [pdm-devel] partially-applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204142451.2992215-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox