From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/3] ui: views: node panel: improve wording for pbs nodes and defuse icon
Date: Wed, 3 Dec 2025 09:23:26 +0100 [thread overview]
Message-ID: <20251203082340.691425-1-d.csapak@proxmox.com> (raw)
using a warning icon instead of an error one defuses this error a bit.
Also include the the total amount of pbs nodes in the error.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/dashboard/node_status_panel.rs | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/ui/src/dashboard/node_status_panel.rs b/ui/src/dashboard/node_status_panel.rs
index 1c37c8e3..a93e03a7 100644
--- a/ui/src/dashboard/node_status_panel.rs
+++ b/ui/src/dashboard/node_status_panel.rs
@@ -141,8 +141,11 @@ fn map_status(
tr!("{0} of an unknown number of nodes online", online),
),
Some(RemoteType::Pbs) => (
- Status::Error.into(),
- tr!("{0} remotes failed", failed_remotes),
+ Status::Warning.into(),
+ tr!(
+ "One of {0} nodes online" | "{n} of {0} nodes online" % *online,
+ online + failed_remotes as u64
+ ),
),
},
NodeStatusCount { online, .. } => (Status::Success.into(), tr!("{0} nodes online", online)),
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-12-03 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 8:23 Dominik Csapak [this message]
2025-12-03 8:23 ` [pdm-devel] [PATCH datacenter-manager 2/3] ui: views: remote panel: improve and defuse error for unreachable remotes Dominik Csapak
2025-12-03 8:23 ` [pdm-devel] [PATCH datacenter-manager 3/3] ui: views: remote panel: center error text Dominik Csapak
2025-12-03 9:40 ` [pdm-devel] [PATCH datacenter-manager 1/3] ui: views: node panel: improve wording for pbs nodes and defuse icon Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203082340.691425-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox