public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [RFC datacenter-manager] ui: rename PBS node slug to overview as stop-gap for search routing
@ 2025-12-02  8:31 Christian Ebner
  2025-12-02  9:00 ` [pdm-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2025-12-02  8:31 UTC (permalink / raw)
  To: pdm-devel

This makes sure that the correct view is rendered when searching and
clicking on a PBS datastore while being on a panel not related to the
PBS remotes.

The search produces the correct path in navigate_to() when the
PdmResourceTree triggers Msg::NavigateToEntry, setting this via
the navigator(). The result is however still being the node status
view slug to be appended, which leads to datastores being displayed
incorrectly. By setting the slug to `overview`, it now works for both
cases.

This is intended as temporary stop-gap until the actual routing
behaviour is fixed.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Still unsure how the actual routing behaviour is, but it seems to be
related to the node status pushing the slug to the path somehow.
This seems to also depend on whether the node was selected first or
not.

Please ignore if you do not see this fitting as stop-gap.

 ui/src/pbs/node/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
index 2033bb1..e32c2c6 100644
--- a/ui/src/pbs/node/mod.rs
+++ b/ui/src/pbs/node/mod.rs
@@ -70,7 +70,7 @@ impl yew::Component for PbsNodePanelComp {
             .class(ColorScheme::Neutral)
             .with_item_builder(
                 TabBarItem::new()
-                    .key("status_view")
+                    .key("overview")
                     .label(tr!("Overview"))
                     .icon_class("fa fa-tachometer"),
                 {
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pdm-devel] applied: [RFC datacenter-manager] ui: rename PBS node slug to overview as stop-gap for search routing
  2025-12-02  8:31 [pdm-devel] [RFC datacenter-manager] ui: rename PBS node slug to overview as stop-gap for search routing Christian Ebner
@ 2025-12-02  9:00 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-12-02  9:00 UTC (permalink / raw)
  To: pdm-devel, Christian Ebner

On Tue, 02 Dec 2025 09:31:52 +0100, Christian Ebner wrote:
> This makes sure that the correct view is rendered when searching and
> clicking on a PBS datastore while being on a panel not related to the
> PBS remotes.
> 
> The search produces the correct path in navigate_to() when the
> PdmResourceTree triggers Msg::NavigateToEntry, setting this via
> the navigator(). The result is however still being the node status
> view slug to be appended, which leads to datastores being displayed
> incorrectly. By setting the slug to `overview`, it now works for both
> cases.
> 
> [...]

Applied, thanks!

[1/1] ui: rename PBS node slug to overview as stop-gap for search routing
      commit: e9bd89ed885f4e2dd3b7cdd92af3bc6ce31e5337


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-02  9:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-02  8:31 [pdm-devel] [RFC datacenter-manager] ui: rename PBS node slug to overview as stop-gap for search routing Christian Ebner
2025-12-02  9:00 ` [pdm-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal