[pdm-devel] [PATCH datacenter-manager] ui: pve: node: cleanup

[pdm-devel] [PATCH datacenter-manager] ui: pve: node: cleanup

[Dominik Csapak]

the changed method will only be called if the properties change and
return true if none is given. So returning true when any property
changed is already the default behavior, no need for us to implement it
again.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/pve/node/mod.rs | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/ui/src/pve/node/mod.rs b/ui/src/pve/node/mod.rs
index 66ce8dda..1fcd92eb 100644
--- a/ui/src/pve/node/mod.rs
+++ b/ui/src/pve/node/mod.rs
@@ -2,10 +2,7 @@ use std::rc::Rc;
 
 use gloo_utils::window;
 use proxmox_yew_comp::{AptPackageManager, ConsoleType, XTermJs};
-use yew::{
-    virtual_dom::{VComp, VNode},
-    Context,
-};
+use yew::virtual_dom::{VComp, VNode};
 
 use pwt::{
     css::{AlignItems, ColorScheme},
@@ -51,12 +48,6 @@ impl yew::Component for PveNodePanelComp {
         Self
     }
 
-    fn changed(&mut self, ctx: &Context<Self>, old_props: &Self::Properties) -> bool {
-        let props = ctx.props();
-
-        props.remote != old_props.remote || props.node != old_props.node
-    }
-
     fn view(&self, ctx: &yew::Context<Self>) -> yew::Html {
         let props = ctx.props();
 
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH datacenter-manager] ui: pve: node: cleanup

[Thomas Lamprecht]

On Fri, 28 Nov 2025 11:47:55 +0100, Dominik Csapak wrote:
> the changed method will only be called if the properties change and
> return true if none is given. So returning true when any property
> changed is already the default behavior, no need for us to implement it
> again.
> 
> 

Applied, thanks!

[1/1] ui: pve: node: cleanup
      commit: 3cdca4e9e5cfba535f61853a9e64d5f2359ebb92


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel