From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager] ui: pve: node: cleanup
Date: Fri, 28 Nov 2025 11:47:55 +0100 [thread overview]
Message-ID: <20251128104800.1811360-1-d.csapak@proxmox.com> (raw)
the changed method will only be called if the properties change and
return true if none is given. So returning true when any property
changed is already the default behavior, no need for us to implement it
again.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/pve/node/mod.rs | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/ui/src/pve/node/mod.rs b/ui/src/pve/node/mod.rs
index 66ce8dda..1fcd92eb 100644
--- a/ui/src/pve/node/mod.rs
+++ b/ui/src/pve/node/mod.rs
@@ -2,10 +2,7 @@ use std::rc::Rc;
use gloo_utils::window;
use proxmox_yew_comp::{AptPackageManager, ConsoleType, XTermJs};
-use yew::{
- virtual_dom::{VComp, VNode},
- Context,
-};
+use yew::virtual_dom::{VComp, VNode};
use pwt::{
css::{AlignItems, ColorScheme},
@@ -51,12 +48,6 @@ impl yew::Component for PveNodePanelComp {
Self
}
- fn changed(&mut self, ctx: &Context<Self>, old_props: &Self::Properties) -> bool {
- let props = ctx.props();
-
- props.remote != old_props.remote || props.node != old_props.node
- }
-
fn view(&self, ctx: &yew::Context<Self>) -> yew::Html {
let props = ctx.props();
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-11-28 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 10:47 Dominik Csapak [this message]
2025-11-28 18:53 ` [pdm-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128104800.1811360-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox