public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v5 19/26] ui: dashboard: add current view to search terms
Date: Wed, 26 Nov 2025 16:18:12 +0100	[thread overview]
Message-ID: <20251126151833.3637080-20-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251126151833.3637080-1-d.csapak@proxmox.com>

by providing a `ViewContext` that contains the name of the current view
and utilizing that in the dashboard widget when searching for some term.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 lib/pdm-search/src/lib.rs                |  9 +++++++
 ui/src/dashboard/guest_panel.rs          |  4 +++-
 ui/src/dashboard/node_status_panel.rs    |  4 +++-
 ui/src/dashboard/pbs_datastores_panel.rs |  4 +++-
 ui/src/dashboard/remote_panel.rs         |  4 +++-
 ui/src/dashboard/sdn_zone_panel.rs       |  8 +++++--
 ui/src/dashboard/view.rs                 | 30 +++++++++++++++++++++++-
 7 files changed, 56 insertions(+), 7 deletions(-)

diff --git a/lib/pdm-search/src/lib.rs b/lib/pdm-search/src/lib.rs
index fa484cf4..cb9119f6 100644
--- a/lib/pdm-search/src/lib.rs
+++ b/lib/pdm-search/src/lib.rs
@@ -68,6 +68,15 @@ impl Search {
 
         true
     }
+
+    /// Add a term to the search
+    pub fn add_term(&mut self, term: SearchTerm) {
+        if term.is_optional() {
+            self.optional_terms.push(term);
+        } else {
+            self.required_terms.push(term);
+        }
+    }
 }
 
 impl fmt::Display for Search {
diff --git a/ui/src/dashboard/guest_panel.rs b/ui/src/dashboard/guest_panel.rs
index 8b97fa2b..32c41c22 100644
--- a/ui/src/dashboard/guest_panel.rs
+++ b/ui/src/dashboard/guest_panel.rs
@@ -16,6 +16,7 @@ use pdm_api_types::resource::{GuestStatusCount, ResourceType, ResourcesStatus};
 use pdm_search::{Search, SearchTerm};
 
 use crate::dashboard::create_title_with_icon;
+use crate::dashboard::view::add_current_view_to_search;
 use crate::pve::GuestType;
 use crate::search_provider::get_search_provider;
 use crate::LoadResult;
@@ -59,8 +60,9 @@ impl yew::Component for PdmGuestPanel {
         Self {}
     }
 
-    fn update(&mut self, ctx: &Context<Self>, msg: Self::Message) -> bool {
+    fn update(&mut self, ctx: &Context<Self>, mut msg: Self::Message) -> bool {
         if let Some(provider) = get_search_provider(ctx) {
+            add_current_view_to_search(ctx, &mut msg);
             provider.search(msg);
         }
         false
diff --git a/ui/src/dashboard/node_status_panel.rs b/ui/src/dashboard/node_status_panel.rs
index 60648ef0..032719f2 100644
--- a/ui/src/dashboard/node_status_panel.rs
+++ b/ui/src/dashboard/node_status_panel.rs
@@ -14,6 +14,7 @@ use pdm_api_types::resource::NodeStatusCount;
 use pdm_api_types::{remotes::RemoteType, resource::ResourcesStatus};
 
 use crate::dashboard::create_title_with_icon;
+use crate::dashboard::view::add_current_view_to_search;
 use crate::search_provider::get_search_provider;
 use crate::LoadResult;
 
@@ -60,8 +61,9 @@ impl yew::Component for NodeStatusPanelComponent {
         Self {}
     }
 
-    fn update(&mut self, ctx: &Context<Self>, msg: Self::Message) -> bool {
+    fn update(&mut self, ctx: &Context<Self>, mut msg: Self::Message) -> bool {
         if let Some(provider) = get_search_provider(ctx) {
+            add_current_view_to_search(ctx, &mut msg);
             provider.search(msg);
         }
         false
diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
index 32193ae4..afc83b30 100644
--- a/ui/src/dashboard/pbs_datastores_panel.rs
+++ b/ui/src/dashboard/pbs_datastores_panel.rs
@@ -12,6 +12,7 @@ use pwt::state::SharedState;
 use pwt::widget::{Container, Fa, List, ListTile, Panel};
 
 use crate::dashboard::create_title_with_icon;
+use crate::dashboard::view::add_current_view_to_search;
 use crate::search_provider::get_search_provider;
 use crate::LoadResult;
 
@@ -55,8 +56,9 @@ impl yew::Component for PbsDatastoresPanelComponent {
         Self {}
     }
 
-    fn update(&mut self, ctx: &Context<Self>, msg: Self::Message) -> bool {
+    fn update(&mut self, ctx: &Context<Self>, mut msg: Self::Message) -> bool {
         if let Some(provider) = get_search_provider(ctx) {
+            add_current_view_to_search(ctx, &mut msg);
             provider.search(msg);
         }
 
diff --git a/ui/src/dashboard/remote_panel.rs b/ui/src/dashboard/remote_panel.rs
index a5682d7a..16125a9b 100644
--- a/ui/src/dashboard/remote_panel.rs
+++ b/ui/src/dashboard/remote_panel.rs
@@ -15,6 +15,7 @@ use pwt::widget::{error_message, Column, Container, Fa, Panel};
 
 use pdm_api_types::resource::ResourcesStatus;
 
+use crate::dashboard::view::add_current_view_to_search;
 use crate::LoadResult;
 use crate::{dashboard::create_title_with_icon, search_provider::get_search_provider};
 
@@ -49,8 +50,9 @@ impl Component for PdmRemotePanel {
         Self {}
     }
 
-    fn update(&mut self, ctx: &Context<Self>, msg: Self::Message) -> bool {
+    fn update(&mut self, ctx: &Context<Self>, mut msg: Self::Message) -> bool {
         if let Some(search) = get_search_provider(ctx) {
+            add_current_view_to_search(ctx, &mut msg);
             search.search(msg);
         }
         false
diff --git a/ui/src/dashboard/sdn_zone_panel.rs b/ui/src/dashboard/sdn_zone_panel.rs
index ed734f6f..e5aa8c1a 100644
--- a/ui/src/dashboard/sdn_zone_panel.rs
+++ b/ui/src/dashboard/sdn_zone_panel.rs
@@ -15,7 +15,10 @@ use yew::{
     Properties,
 };
 
-use crate::{dashboard::create_title_with_icon, search_provider::get_search_provider, LoadResult};
+use crate::dashboard::create_title_with_icon;
+use crate::dashboard::view::add_current_view_to_search;
+use crate::search_provider::get_search_provider;
+use crate::LoadResult;
 
 use super::loading_column;
 
@@ -72,8 +75,9 @@ impl yew::Component for SdnZonePanelComponent {
         Self {}
     }
 
-    fn update(&mut self, ctx: &Context<Self>, msg: Self::Message) -> bool {
+    fn update(&mut self, ctx: &Context<Self>, mut msg: Self::Message) -> bool {
         if let Some(provider) = get_search_provider(ctx) {
+            add_current_view_to_search(ctx, &mut msg);
             provider.search(msg);
         }
 
diff --git a/ui/src/dashboard/view.rs b/ui/src/dashboard/view.rs
index 962afb9b..ff287db8 100644
--- a/ui/src/dashboard/view.rs
+++ b/ui/src/dashboard/view.rs
@@ -39,6 +39,7 @@ use pdm_api_types::views::{
 };
 use pdm_api_types::TaskStatistics;
 use pdm_client::types::TopEntities;
+use pdm_search::{Search, SearchTerm};
 
 mod row_view;
 pub use row_view::RowView;
@@ -70,6 +71,12 @@ impl View {
     }
 }
 
+#[derive(PartialEq, Clone)]
+/// Used to provide the current view name via a [`ContextProvider`]
+pub struct ViewContext {
+    pub name: Option<AttrValue>,
+}
+
 pub enum LoadingResult {
     Resources(Result<ResourcesStatus, Error>),
     TopEntities(Result<pdm_client::types::TopEntities, proxmox_client::Error>),
@@ -541,7 +548,15 @@ impl Component for ViewComp {
 
         view.add_optional_child(self.subscriptions_dialog.clone());
 
-        view.into()
+        let view_context = ViewContext {
+            name: props.view.clone(),
+        };
+
+        html! {
+            <ContextProvider<ViewContext> context={view_context}>
+                {view}
+            </ContextProvider<ViewContext>>
+        }
     }
 }
 
@@ -640,3 +655,16 @@ async fn load_template(view: Option<AttrValue>) -> Result<ViewTemplate, Error> {
 
     Ok(template)
 }
+
+/// This adds the current view from the context to the given [`Search`] if any
+pub fn add_current_view_to_search<T: yew::Component>(ctx: &yew::Context<T>, search: &mut Search) {
+    if let Some((context, _)) = ctx.link().context::<ViewContext>(Callback::from(|_| {})) {
+        if let Some(name) = context.name {
+            search.add_term(
+                SearchTerm::new(name.to_string())
+                    .category(Some("view"))
+                    .optional(false),
+            );
+        }
+    }
+}
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-11-26 15:19 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 15:17 [pdm-devel] [PATCH datacenter-manager v5 00/26] enable custom views on the UI Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 01/26] lib: pdm-config: views: add locking/saving methods Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 02/26] lib: api-types: add 'layout' property to ViewConfig Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 03/26] server: api: implement CRUD api for views Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 04/26] server: api: resources: add 'view' category to search syntax Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 05/26] ui: remote selector: allow forcing of value Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 06/26] ui: dashboard types: add missing 'default's to de-serialization Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 07/26] ui: dashboard: status row: add optional 'editing state' Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 08/26] ui: dashboard: prepare view for editing custom views Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 09/26] ui: views: implement view loading from api Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 10/26] ui: views: make 'view' name property optional Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 11/26] ui: views: add 'view' parameter to api calls Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 12/26] ui: views: save updated layout to backend Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 13/26] ui: add view list context Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 14/26] ui: configuration: add view CRUD panels Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 15/26] ui: main menu: add optional view_list property Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 16/26] ui: load view list on page init Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 17/26] lib/ui: move views types to pdm-api-types Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 18/26] server: api: views: check layout string for validity Dominik Csapak
2025-11-26 15:18 ` Dominik Csapak [this message]
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 20/26] ui: resource tree: fix loading logic Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 21/26] ui: resource tree: move error message into first column Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 22/26] ui: resource tree: use `ViewContext` to limit the api calls to a view Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 23/26] ui: resource tree: show guest tags Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 24/26] api-types/ui: add ResourceTree variant for WidgetType Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 25/26] ui: dashboard view: refactor widget rendering arguments into struct Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 26/26] ui: resource tree/view: reload tree in a view on refresh Dominik Csapak
2025-11-26 21:15 ` [pdm-devel] applied: [PATCH datacenter-manager v5 00/26] enable custom views on the UI Thomas Lamprecht
2025-11-26 21:17 ` [pdm-devel] " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126151833.3637080-20-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal