public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v5 09/26] ui: views: implement view loading from api
Date: Wed, 26 Nov 2025 16:18:02 +0100	[thread overview]
Message-ID: <20251126151833.3637080-10-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251126151833.3637080-1-d.csapak@proxmox.com>

by simply loading the config from the api. Also move the default
dashboard into a constant.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/dashboard/view.rs | 179 +++++++++++++++++++++------------------
 1 file changed, 97 insertions(+), 82 deletions(-)

diff --git a/ui/src/dashboard/view.rs b/ui/src/dashboard/view.rs
index 772fa244..d87c5a6d 100644
--- a/ui/src/dashboard/view.rs
+++ b/ui/src/dashboard/view.rs
@@ -8,6 +8,7 @@ use serde_json::json;
 use yew::virtual_dom::{VComp, VNode};
 
 use proxmox_yew_comp::http_get;
+use proxmox_yew_comp::percent_encoding::percent_encode_component;
 use pwt::css;
 use pwt::prelude::*;
 use pwt::props::StorageLocation;
@@ -35,6 +36,7 @@ use crate::{pdm_client, LoadResult};
 use pdm_api_types::remotes::RemoteType;
 use pdm_api_types::resource::ResourcesStatus;
 use pdm_api_types::subscription::RemoteSubscriptions;
+use pdm_api_types::views::ViewConfig;
 use pdm_api_types::TaskStatistics;
 use pdm_client::types::TopEntities;
 
@@ -276,8 +278,9 @@ impl Component for ViewComp {
         );
 
         let async_pool = AsyncPool::new();
+        let view = ctx.props().view.clone();
         async_pool.send_future(ctx.link().clone(), async move {
-            Msg::ViewTemplateLoaded(load_template().await)
+            Msg::ViewTemplateLoaded(load_template(Some(view)).await)
         });
 
         Self {
@@ -368,8 +371,9 @@ impl Component for ViewComp {
     fn changed(&mut self, ctx: &Context<Self>, _old_props: &Self::Properties) -> bool {
         self.async_pool = AsyncPool::new();
         self.load_finished_time = None;
+        let view = ctx.props().view.clone();
         self.async_pool.send_future(ctx.link().clone(), async move {
-            Msg::ViewTemplateLoaded(load_template().await)
+            Msg::ViewTemplateLoaded(load_template(Some(view)).await)
         });
         true
     }
@@ -493,87 +497,98 @@ impl Component for ViewComp {
     }
 }
 
-async fn load_template() -> Result<ViewTemplate, Error> {
-    // FIXME: load template from api
-
-    let view_str = "
-        {
-          \"description\": \"some description\",
-          \"layout\": {
-            \"layout-type\": \"rows\",
-            \"rows\": [
-              [
-                {
-                  \"flex\": 3.0,
-                  \"widget-type\": \"remotes\",
-                  \"show-wizard\": true
-                },
-                {
-                  \"flex\": 3.0,
-                  \"widget-type\": \"nodes\",
-                  \"remote-type\": \"pve\"
-                },
-                {
-                  \"flex\": 3.0,
-                  \"widget-type\": \"guests\",
-                  \"guest-type\": \"qemu\"
-                },
-                {
-                  \"flex\": 3.0,
-                  \"widget-type\": \"nodes\",
-                  \"remote-type\": \"pbs\"
-                },
-                {
-                  \"flex\": 3.0,
-                  \"widget-type\": \"guests\",
-                  \"guest-type\": \"lxc\"
-                },
-                {
-                  \"flex\": 3.0,
-                  \"widget-type\": \"pbs-datastores\"
-                },
-                {
-                  \"flex\": 5.0,
-                  \"widget-type\": \"subscription\"
-                }
-              ],
-              [
-                {
-                  \"widget-type\": \"leaderboard\",
-                  \"leaderboard-type\": \"guest-cpu\"
-                },
-                {
-                  \"widget-type\": \"leaderboard\",
-                  \"leaderboard-type\": \"node-cpu\"
-                },
-                {
-                  \"widget-type\": \"leaderboard\",
-                  \"leaderboard-type\": \"node-memory\"
-                }
-              ],
-              [
-                {
-                  \"flex\": 5.0,
-                  \"widget-type\": \"task-summary\",
-                  \"grouping\": \"category\",
-                  \"sorting\": \"default\"
-                },
-                {
-                  \"flex\": 5.0,
-                  \"widget-type\": \"task-summary\",
-                  \"grouping\": \"remote\",
-                  \"sorting\": \"failed-tasks\"
-                },
-                {
-                  \"flex\": 2.0,
-                  \"widget-type\": \"sdn\"
-                }
-              ]
-            ]
-          }
+const DEFAULT_DASHBOARD: &str = "
+    {
+      \"layout\": {
+        \"layout-type\": \"rows\",
+        \"rows\": [
+          [
+            {
+              \"flex\": 3.0,
+              \"widget-type\": \"remotes\",
+              \"show-wizard\": true
+            },
+            {
+              \"flex\": 3.0,
+              \"widget-type\": \"nodes\",
+              \"remote-type\": \"pve\"
+            },
+            {
+              \"flex\": 3.0,
+              \"widget-type\": \"guests\",
+              \"guest-type\": \"qemu\"
+            },
+            {
+              \"flex\": 3.0,
+              \"widget-type\": \"nodes\",
+              \"remote-type\": \"pbs\"
+            },
+            {
+              \"flex\": 3.0,
+              \"widget-type\": \"guests\",
+              \"guest-type\": \"lxc\"
+            },
+            {
+              \"flex\": 3.0,
+              \"widget-type\": \"pbs-datastores\"
+            },
+            {
+              \"flex\": 5.0,
+              \"widget-type\": \"subscription\"
+            }
+          ],
+          [
+            {
+              \"widget-type\": \"leaderboard\",
+              \"leaderboard-type\": \"guest-cpu\"
+            },
+            {
+              \"widget-type\": \"leaderboard\",
+              \"leaderboard-type\": \"node-cpu\"
+            },
+            {
+              \"widget-type\": \"leaderboard\",
+              \"leaderboard-type\": \"node-memory\"
+            }
+          ],
+          [
+            {
+              \"flex\": 5.0,
+              \"widget-type\": \"task-summary\",
+              \"grouping\": \"category\",
+              \"sorting\": \"default\"
+            },
+            {
+              \"flex\": 5.0,
+              \"widget-type\": \"task-summary\",
+              \"grouping\": \"remote\",
+              \"sorting\": \"failed-tasks\"
+            },
+            {
+              \"flex\": 2.0,
+              \"widget-type\": \"sdn\"
+            }
+          ]
+        ]
+      }
+    }
+";
+
+async fn load_template(view: Option<AttrValue>) -> Result<ViewTemplate, Error> {
+    let view_str = match view {
+        Some(view) => {
+            let view = percent_encode_component(view.as_str());
+            let config: ViewConfig = http_get(&format!("/config/views/{view}"), None).await?;
+            config.layout
         }
-    ";
+        None => String::new(),
+    };
+
+    let template: ViewTemplate = if view_str.is_empty() {
+        serde_json::from_str(DEFAULT_DASHBOARD)?
+    } else {
+        serde_json::from_str(&view_str)?
+    };
 
-    let template: ViewTemplate = serde_json::from_str(view_str)?;
     Ok(template)
 }
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-11-26 15:19 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 15:17 [pdm-devel] [PATCH datacenter-manager v5 00/26] enable custom views on the UI Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 01/26] lib: pdm-config: views: add locking/saving methods Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 02/26] lib: api-types: add 'layout' property to ViewConfig Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 03/26] server: api: implement CRUD api for views Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 04/26] server: api: resources: add 'view' category to search syntax Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 05/26] ui: remote selector: allow forcing of value Dominik Csapak
2025-11-26 15:17 ` [pdm-devel] [PATCH datacenter-manager v5 06/26] ui: dashboard types: add missing 'default's to de-serialization Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 07/26] ui: dashboard: status row: add optional 'editing state' Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 08/26] ui: dashboard: prepare view for editing custom views Dominik Csapak
2025-11-26 15:18 ` Dominik Csapak [this message]
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 10/26] ui: views: make 'view' name property optional Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 11/26] ui: views: add 'view' parameter to api calls Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 12/26] ui: views: save updated layout to backend Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 13/26] ui: add view list context Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 14/26] ui: configuration: add view CRUD panels Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 15/26] ui: main menu: add optional view_list property Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 16/26] ui: load view list on page init Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 17/26] lib/ui: move views types to pdm-api-types Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 18/26] server: api: views: check layout string for validity Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 19/26] ui: dashboard: add current view to search terms Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 20/26] ui: resource tree: fix loading logic Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 21/26] ui: resource tree: move error message into first column Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 22/26] ui: resource tree: use `ViewContext` to limit the api calls to a view Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 23/26] ui: resource tree: show guest tags Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 24/26] api-types/ui: add ResourceTree variant for WidgetType Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 25/26] ui: dashboard view: refactor widget rendering arguments into struct Dominik Csapak
2025-11-26 15:18 ` [pdm-devel] [PATCH datacenter-manager v5 26/26] ui: resource tree/view: reload tree in a view on refresh Dominik Csapak
2025-11-26 21:15 ` [pdm-devel] applied: [PATCH datacenter-manager v5 00/26] enable custom views on the UI Thomas Lamprecht
2025-11-26 21:17 ` [pdm-devel] " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126151833.3637080-10-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal