* [pdm-devel] [PATCH datacenter-manager] ui: tasks: fix base_url for pbs task logs
@ 2025-11-26 13:18 Dominik Csapak
2025-11-27 8:53 ` [pdm-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-11-26 13:18 UTC (permalink / raw)
To: pdm-devel
in the top nav bar and the dashboard filtered tasks.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/dashboard/filtered_tasks.rs | 3 +--
ui/src/top_nav_bar.rs | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/ui/src/dashboard/filtered_tasks.rs b/ui/src/dashboard/filtered_tasks.rs
index 5be3bc8c..fa59e598 100644
--- a/ui/src/dashboard/filtered_tasks.rs
+++ b/ui/src/dashboard/filtered_tasks.rs
@@ -175,8 +175,7 @@ impl Component for PdmFilteredTasks {
}
if let Some((upid, endtime)) = &self.task_info {
- // TODO PBS
- let base_url = format!("/pve/remotes/{}/tasks", upid.remote());
+ let base_url = format!("/{}/remotes/{}/tasks", upid.remote_type(), upid.remote());
TaskViewer::new(upid.to_string())
.endtime(endtime)
.base_url(base_url)
diff --git a/ui/src/top_nav_bar.rs b/ui/src/top_nav_bar.rs
index 11e78d6c..7e2af711 100644
--- a/ui/src/top_nav_bar.rs
+++ b/ui/src/top_nav_bar.rs
@@ -236,11 +236,10 @@ impl Component for PdmTopNavBar {
.on_close(ctx.link().callback(|_| Msg::ChangeView(None)))
.into(),
ViewState::OpenTask((task_id, _endtime)) => {
- // TODO PBS
let base_url = task_id
.parse::<RemoteUpid>()
.ok()
- .map(|upid| format!("/pve/remotes/{}/tasks", upid.remote()));
+ .map(|upid| format!("/{}/remotes/{}/tasks", upid.remote_type(), upid.remote()));
TaskViewer::new(task_id)
.base_url(base_url.unwrap_or("/nodes/localhost/tasks".to_string()))
.on_close(ctx.link().callback(|_| Msg::ChangeView(None)))
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pdm-devel] applied: [PATCH datacenter-manager] ui: tasks: fix base_url for pbs task logs
2025-11-26 13:18 [pdm-devel] [PATCH datacenter-manager] ui: tasks: fix base_url for pbs task logs Dominik Csapak
@ 2025-11-27 8:53 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-11-27 8:53 UTC (permalink / raw)
To: pdm-devel, Dominik Csapak
On Wed, 26 Nov 2025 14:18:50 +0100, Dominik Csapak wrote:
> in the top nav bar and the dashboard filtered tasks.
>
>
Applied, thanks!
[1/1] ui: tasks: fix base_url for pbs task logs
commit: 2e9b16720549c1264cd00f2819053e6dc981a376
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-27 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-26 13:18 [pdm-devel] [PATCH datacenter-manager] ui: tasks: fix base_url for pbs task logs Dominik Csapak
2025-11-27 8:53 ` [pdm-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox