From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager] ui: tasks: fix base_url for pbs task logs
Date: Wed, 26 Nov 2025 14:18:50 +0100 [thread overview]
Message-ID: <20251126131859.2745340-1-d.csapak@proxmox.com> (raw)
in the top nav bar and the dashboard filtered tasks.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/dashboard/filtered_tasks.rs | 3 +--
ui/src/top_nav_bar.rs | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/ui/src/dashboard/filtered_tasks.rs b/ui/src/dashboard/filtered_tasks.rs
index 5be3bc8c..fa59e598 100644
--- a/ui/src/dashboard/filtered_tasks.rs
+++ b/ui/src/dashboard/filtered_tasks.rs
@@ -175,8 +175,7 @@ impl Component for PdmFilteredTasks {
}
if let Some((upid, endtime)) = &self.task_info {
- // TODO PBS
- let base_url = format!("/pve/remotes/{}/tasks", upid.remote());
+ let base_url = format!("/{}/remotes/{}/tasks", upid.remote_type(), upid.remote());
TaskViewer::new(upid.to_string())
.endtime(endtime)
.base_url(base_url)
diff --git a/ui/src/top_nav_bar.rs b/ui/src/top_nav_bar.rs
index 11e78d6c..7e2af711 100644
--- a/ui/src/top_nav_bar.rs
+++ b/ui/src/top_nav_bar.rs
@@ -236,11 +236,10 @@ impl Component for PdmTopNavBar {
.on_close(ctx.link().callback(|_| Msg::ChangeView(None)))
.into(),
ViewState::OpenTask((task_id, _endtime)) => {
- // TODO PBS
let base_url = task_id
.parse::<RemoteUpid>()
.ok()
- .map(|upid| format!("/pve/remotes/{}/tasks", upid.remote()));
+ .map(|upid| format!("/{}/remotes/{}/tasks", upid.remote_type(), upid.remote()));
TaskViewer::new(task_id)
.base_url(base_url.unwrap_or("/nodes/localhost/tasks".to_string()))
.on_close(ctx.link().callback(|_| Msg::ChangeView(None)))
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-11-26 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 13:18 Dominik Csapak [this message]
2025-11-27 8:53 ` [pdm-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126131859.2745340-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox