From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v4 06/18] ui: dashboard types: add missing 'default's to de-serialization
Date: Mon, 24 Nov 2025 13:07:38 +0100 [thread overview]
Message-ID: <20251124120758.2636462-7-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251124120758.2636462-1-d.csapak@proxmox.com>
otherwise a layout with no rows or empty description can be serialized,
but not deserialized.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v3:
* fix typo in commit message
* also add the default to the description, same problem
ui/src/dashboard/types.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/src/dashboard/types.rs b/ui/src/dashboard/types.rs
index c79c38ab..df4a3668 100644
--- a/ui/src/dashboard/types.rs
+++ b/ui/src/dashboard/types.rs
@@ -7,7 +7,7 @@ use crate::pve::GuestType;
#[derive(Serialize, Deserialize, PartialEq, Clone)]
#[serde(rename_all = "kebab-case")]
pub struct ViewTemplate {
- #[serde(skip_serializing_if = "String::is_empty")]
+ #[serde(default, skip_serializing_if = "String::is_empty")]
pub description: String,
pub layout: ViewLayout,
}
@@ -17,7 +17,7 @@ pub struct ViewTemplate {
#[serde(tag = "layout-type")]
pub enum ViewLayout {
Rows {
- #[serde(skip_serializing_if = "Vec::is_empty")]
+ #[serde(default, skip_serializing_if = "Vec::is_empty")]
rows: Vec<Vec<RowWidget>>,
},
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-11-24 12:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 12:07 [pdm-devel] [PATCH datacenter-manager v4 00/18] enable custom views on the UI Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 01/18] lib: pdm-config: views: add locking/saving methods Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 02/18] lib: api-types: add 'layout' property to ViewConfig Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 03/18] server: api: implement CRUD api for views Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 04/18] server: api: resources: add 'view' category to search syntax Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 05/18] ui: remote selector: allow forcing of value Dominik Csapak
2025-11-24 12:07 ` Dominik Csapak [this message]
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 07/18] ui: dashboard: status row: add optional 'editing state' Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 08/18] ui: dashboard: prepare view for editing custom views Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 09/18] ui: views: implement view loading from api Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 10/18] ui: views: make 'view' name property optional Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 11/18] ui: views: add 'view' parameter to api calls Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 12/18] ui: views: save updated layout to backend Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 13/18] ui: add view list context Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 14/18] ui: configuration: add view CRUD panels Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 15/18] ui: main menu: add optional view_list property Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 16/18] ui: load view list on page init Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 17/18] lib/ui: move views types to pdm-api-types Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 18/18] server: api: views: check layout string for validity Dominik Csapak
2025-11-26 15:20 ` [pdm-devel] superseded: [PATCH datacenter-manager v4 00/18] enable custom views on the UI Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124120758.2636462-7-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox