From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 4/4] ui: pve: rename NodePanel to PveNodePanel
Date: Thu, 20 Nov 2025 11:36:20 +0100 [thread overview]
Message-ID: <20251120103620.128741-5-l.wagner@proxmox.com> (raw)
In-Reply-To: <20251120103620.128741-1-l.wagner@proxmox.com>
For consistency with the PBS variants of those components.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
ui/src/pve/mod.rs | 2 +-
ui/src/pve/node/mod.rs | 20 ++++++++++----------
ui/src/pve/node/overview.rs | 20 ++++++++++----------
3 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/ui/src/pve/mod.rs b/ui/src/pve/mod.rs
index c0759f18..a3448ae1 100644
--- a/ui/src/pve/mod.rs
+++ b/ui/src/pve/mod.rs
@@ -178,7 +178,7 @@ impl LoadableComponent for PveRemoteComp {
.with_child(RemoteTaskList::new().remote(remote.clone()))
.into(),
PveTreeNode::Node(node) => {
- node::NodePanel::new(remote.clone(), node.node.clone()).into()
+ node::PveNodePanel::new(remote.clone(), node.node.clone()).into()
}
PveTreeNode::Qemu(qemu) => {
qemu::QemuPanel::new(remote.clone(), qemu.node.clone(), qemu.clone()).into()
diff --git a/ui/src/pve/node/mod.rs b/ui/src/pve/node/mod.rs
index aba5d327..de79185a 100644
--- a/ui/src/pve/node/mod.rs
+++ b/ui/src/pve/node/mod.rs
@@ -16,12 +16,12 @@ use pwt::{
mod overview;
-use overview::NodeOverviewPanel;
+use overview::PveNodeOverviewPanel;
use crate::get_deep_url;
#[derive(Clone, Debug, Eq, PartialEq, Properties)]
-pub struct NodePanel {
+pub struct PveNodePanel {
/// The remote to show
pub remote: String,
@@ -29,23 +29,23 @@ pub struct NodePanel {
pub node: String,
}
-impl NodePanel {
+impl PveNodePanel {
pub fn new(remote: String, node: String) -> Self {
yew::props!(Self { remote, node })
}
}
-impl From<NodePanel> for VNode {
- fn from(val: NodePanel) -> Self {
- VComp::new::<NodePanelComp>(Rc::new(val), None).into()
+impl From<PveNodePanel> for VNode {
+ fn from(val: PveNodePanel) -> Self {
+ VComp::new::<PveNodePanelComp>(Rc::new(val), None).into()
}
}
-pub struct NodePanelComp;
+struct PveNodePanelComp;
-impl yew::Component for NodePanelComp {
+impl yew::Component for PveNodePanelComp {
type Message = ();
- type Properties = NodePanel;
+ type Properties = PveNodePanel;
fn create(_ctx: &yew::Context<Self>) -> Self {
Self
@@ -79,7 +79,7 @@ impl yew::Component for NodePanelComp {
{
let remote = props.remote.clone();
let node = props.node.clone();
- move |_| NodeOverviewPanel::new(remote.clone(), node.clone()).into()
+ move |_| PveNodeOverviewPanel::new(remote.clone(), node.clone()).into()
},
)
.with_item_builder(
diff --git a/ui/src/pve/node/overview.rs b/ui/src/pve/node/overview.rs
index 3803f189..cd9bc014 100644
--- a/ui/src/pve/node/overview.rs
+++ b/ui/src/pve/node/overview.rs
@@ -20,7 +20,7 @@ use pdm_client::types::NodeStatus;
use crate::{renderer::separator, LoadResult};
#[derive(Clone, Debug, Eq, PartialEq, Properties)]
-pub struct NodeOverviewPanel {
+pub struct PveNodeOverviewPanel {
/// The remote to show
pub remote: String,
@@ -36,19 +36,19 @@ pub struct NodeOverviewPanel {
pub status_interval: u32,
}
-impl NodeOverviewPanel {
+impl PveNodeOverviewPanel {
pub fn new(remote: String, node: String) -> Self {
yew::props!(Self { remote, node })
}
}
-impl From<NodeOverviewPanel> for VNode {
- fn from(val: NodeOverviewPanel) -> Self {
- VComp::new::<NodeOverviewPanelComp>(Rc::new(val), None).into()
+impl From<PveNodeOverviewPanel> for VNode {
+ fn from(val: PveNodeOverviewPanel) -> Self {
+ VComp::new::<PveNodeOverviewPanelComp>(Rc::new(val), None).into()
}
}
-pub enum Msg {
+enum Msg {
ReloadRrd,
ReloadStatus,
LoadFinished(Result<Vec<NodeDataPoint>, proxmox_client::Error>),
@@ -56,7 +56,7 @@ pub enum Msg {
UpdateRrdTimeframe(RRDTimeframe),
}
-pub struct NodeOverviewPanelComp {
+struct PveNodeOverviewPanelComp {
time_data: Rc<Vec<i64>>,
cpu_data: Rc<Series>,
load_data: Rc<Series>,
@@ -73,7 +73,7 @@ pub struct NodeOverviewPanelComp {
_status_timeout: Option<gloo_timers::callback::Timeout>,
}
-impl NodeOverviewPanelComp {
+impl PveNodeOverviewPanelComp {
async fn reload_rrd(remote: &str, node: &str, rrd_time_frame: RRDTimeframe) -> Msg {
let res = crate::pdm_client()
.pve_node_rrddata(remote, node, rrd_time_frame.mode, rrd_time_frame.timeframe)
@@ -88,9 +88,9 @@ impl NodeOverviewPanelComp {
}
}
-impl yew::Component for NodeOverviewPanelComp {
+impl yew::Component for PveNodeOverviewPanelComp {
type Message = Msg;
- type Properties = NodeOverviewPanel;
+ type Properties = PveNodeOverviewPanel;
fn create(ctx: &yew::Context<Self>) -> Self {
ctx.link().send_message(Msg::ReloadRrd);
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-11-20 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 10:36 [pdm-devel] [PATCH datacenter-manager 0/4] add 'Updates' tab for PBS remotes Lukas Wagner
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 1/4] ui: move pbs node overview panel from pbs::remote to pbs::node::overview Lukas Wagner
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 2/4] ui: pbs: rename RemoteOverviewPanel to PbsNodeOverviewPanel Lukas Wagner
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 3/4] ui: pbs: move node overview to tab and add update tab Lukas Wagner
2025-11-20 15:52 ` Michael Köppl
2025-11-20 10:36 ` Lukas Wagner [this message]
2025-11-20 15:56 ` [pdm-devel] [PATCH datacenter-manager 0/4] add 'Updates' tab for PBS remotes Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120103620.128741-5-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox