public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 2/4] ui: pbs: rename RemoteOverviewPanel to PbsNodeOverviewPanel
Date: Thu, 20 Nov 2025 11:36:18 +0100	[thread overview]
Message-ID: <20251120103620.128741-3-l.wagner@proxmox.com> (raw)
In-Reply-To: <20251120103620.128741-1-l.wagner@proxmox.com>

Mainly for consistency with the PVE components.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 ui/src/pbs/mod.rs           |  4 ++--
 ui/src/pbs/node/overview.rs | 20 ++++++++++----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/ui/src/pbs/mod.rs b/ui/src/pbs/mod.rs
index 6d71bafc..1fdb417f 100644
--- a/ui/src/pbs/mod.rs
+++ b/ui/src/pbs/mod.rs
@@ -24,7 +24,7 @@ pub use datastore::DatastorePanel;
 mod namespace_selector;
 
 mod node;
-use node::overview::RemoteOverviewPanel;
+use node::overview::PbsNodeOverviewPanel;
 
 mod snapshot_list;
 pub use snapshot_list::SnapshotList;
@@ -108,7 +108,7 @@ impl LoadableComponent for PbsRemoteComp {
         let props = ctx.props();
 
         let content: Html = match &self.view {
-            tree::PbsTreeNode::Root => RemoteOverviewPanel::new(props.remote.clone()).into(),
+            tree::PbsTreeNode::Root => PbsNodeOverviewPanel::new(props.remote.clone()).into(),
             tree::PbsTreeNode::Datastore(data_store_config) => {
                 DatastorePanel::new(props.remote.clone(), data_store_config.clone()).into()
             }
diff --git a/ui/src/pbs/node/overview.rs b/ui/src/pbs/node/overview.rs
index bba57dad..d15eda04 100644
--- a/ui/src/pbs/node/overview.rs
+++ b/ui/src/pbs/node/overview.rs
@@ -20,7 +20,7 @@ use pdm_api_types::rrddata::PbsNodeDataPoint;
 use crate::{renderer::separator, LoadResult};
 
 #[derive(Clone, Debug, Eq, PartialEq, Properties)]
-pub struct RemoteOverviewPanel {
+pub struct PbsNodeOverviewPanel {
     /// The remote to show
     pub remote: String,
 
@@ -33,19 +33,19 @@ pub struct RemoteOverviewPanel {
     pub status_interval: u32,
 }
 
-impl RemoteOverviewPanel {
+impl PbsNodeOverviewPanel {
     pub fn new(remote: String) -> Self {
         yew::props!(Self { remote })
     }
 }
 
-impl From<RemoteOverviewPanel> for VNode {
-    fn from(val: RemoteOverviewPanel) -> Self {
-        VComp::new::<RemoteOverviewPanelComp>(Rc::new(val), None).into()
+impl From<PbsNodeOverviewPanel> for VNode {
+    fn from(val: PbsNodeOverviewPanel) -> Self {
+        VComp::new::<PbsNodeOverviewPanelComp>(Rc::new(val), None).into()
     }
 }
 
-pub enum Msg {
+enum Msg {
     ReloadRrd,
     ReloadStatus,
     LoadFinished(Result<Vec<PbsNodeDataPoint>, proxmox_client::Error>),
@@ -53,7 +53,7 @@ pub enum Msg {
     UpdateRrdTimeframe(RRDTimeframe),
 }
 
-pub struct RemoteOverviewPanelComp {
+struct PbsNodeOverviewPanelComp {
     time_data: Rc<Vec<i64>>,
     cpu_data: Rc<Series>,
     load_data: Rc<Series>,
@@ -70,7 +70,7 @@ pub struct RemoteOverviewPanelComp {
     _status_timeout: Option<gloo_timers::callback::Timeout>,
 }
 
-impl RemoteOverviewPanelComp {
+impl PbsNodeOverviewPanelComp {
     async fn reload_rrd(remote: &str, rrd_time_frame: RRDTimeframe) -> Msg {
         let res = crate::pdm_client()
             .pbs_node_rrddata(remote, rrd_time_frame.mode, rrd_time_frame.timeframe)
@@ -85,9 +85,9 @@ impl RemoteOverviewPanelComp {
     }
 }
 
-impl yew::Component for RemoteOverviewPanelComp {
+impl yew::Component for PbsNodeOverviewPanelComp {
     type Message = Msg;
-    type Properties = RemoteOverviewPanel;
+    type Properties = PbsNodeOverviewPanel;
 
     fn create(ctx: &yew::Context<Self>) -> Self {
         ctx.link().send_message(Msg::ReloadRrd);
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-11-20 10:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 10:36 [pdm-devel] [PATCH datacenter-manager 0/4] add 'Updates' tab for PBS remotes Lukas Wagner
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 1/4] ui: move pbs node overview panel from pbs::remote to pbs::node::overview Lukas Wagner
2025-11-20 10:36 ` Lukas Wagner [this message]
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 3/4] ui: pbs: move node overview to tab and add update tab Lukas Wagner
2025-11-20 15:52   ` Michael Köppl
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 4/4] ui: pve: rename NodePanel to PveNodePanel Lukas Wagner
2025-11-20 15:56 ` [pdm-devel] [PATCH datacenter-manager 0/4] add 'Updates' tab for PBS remotes Michael Köppl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120103620.128741-3-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal