public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v2 07/18] ui: dashboard: status row: add optional 'editing state'
Date: Fri, 14 Nov 2025 13:11:21 +0100	[thread overview]
Message-ID: <20251114121218.2479318-8-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251114121218.2479318-1-d.csapak@proxmox.com>

If that is given, enable some editing buttons (start, finish, cancel) so
that a listener on that editing state can react to those actions.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/dashboard/status_row.rs | 60 +++++++++++++++++++++++++++++++++-
 ui/src/dashboard/view.rs       |  7 ++++
 2 files changed, 66 insertions(+), 1 deletion(-)

diff --git a/ui/src/dashboard/status_row.rs b/ui/src/dashboard/status_row.rs
index 0855b123..e1af6697 100644
--- a/ui/src/dashboard/status_row.rs
+++ b/ui/src/dashboard/status_row.rs
@@ -1,17 +1,23 @@
 use gloo_timers::callback::Interval;
+use yew::html::IntoPropValue;
 use yew::{Component, Properties};
 
+use pwt::css;
 use pwt::prelude::*;
+use pwt::state::SharedState;
 use pwt::{
     css::AlignItems,
     widget::{ActionIcon, Container, Row, Tooltip},
 };
-use pwt_macros::widget;
+use pwt_macros::{builder, widget};
 
 use proxmox_yew_comp::utils::render_epoch;
 
+use crate::dashboard::view::EditingMessage;
+
 #[widget(comp=PdmDashboardStatusRow)]
 #[derive(Properties, PartialEq, Clone)]
+#[builder]
 pub struct DashboardStatusRow {
     last_refresh: Option<f64>,
     reload_interval_s: u32,
@@ -19,6 +25,11 @@ pub struct DashboardStatusRow {
     on_reload: Callback<bool>,
 
     on_settings_click: Callback<()>,
+
+    #[builder(IntoPropValue, into_prop_value)]
+    #[prop_or_default]
+    /// If added, shows a edit/finish/cancel button
+    editing_state: Option<SharedState<Vec<EditingMessage>>>,
 }
 
 impl DashboardStatusRow {
@@ -40,12 +51,14 @@ impl DashboardStatusRow {
 pub enum Msg {
     /// The bool denotes if the reload comes from the click or the timer.
     Reload(bool),
+    Edit(EditingMessage),
 }
 
 #[doc(hidden)]
 pub struct PdmDashboardStatusRow {
     _interval: Interval,
     loading: bool,
+    edit: bool,
 }
 
 impl PdmDashboardStatusRow {
@@ -70,6 +83,7 @@ impl Component for PdmDashboardStatusRow {
         Self {
             _interval: Self::create_interval(ctx),
             loading: false,
+            edit: false,
         }
     }
 
@@ -81,6 +95,13 @@ impl Component for PdmDashboardStatusRow {
                 self.loading = true;
                 true
             }
+            Msg::Edit(editing) => {
+                self.edit = matches!(editing, EditingMessage::Start);
+                if let Some(state) = props.editing_state.as_ref() {
+                    state.write().push(editing);
+                }
+                true
+            }
         }
     }
 
@@ -121,6 +142,43 @@ impl Component for PdmDashboardStatusRow {
                 None => tr!("Now refreshing"),
             }))
             .with_flex_spacer()
+            .with_optional_child(props.editing_state.clone().and_then(|_| {
+                (!self.edit).then_some({
+                    Tooltip::new(ActionIcon::new("fa fa-pencil").tabindex(0).on_activate({
+                        ctx.link()
+                            .callback(move |_| Msg::Edit(EditingMessage::Start))
+                    }))
+                    .tip(tr!("Edit"))
+                })
+            }))
+            .with_optional_child(props.editing_state.clone().and_then(|_| {
+                self.edit.then_some({
+                    Tooltip::new(
+                        ActionIcon::new("fa fa-check")
+                            .class(css::ColorScheme::Success)
+                            .tabindex(0)
+                            .on_activate({
+                                ctx.link()
+                                    .callback(move |_| Msg::Edit(EditingMessage::Finish))
+                            }),
+                    )
+                    .tip(tr!("Finish Editing"))
+                })
+            }))
+            .with_optional_child(props.editing_state.clone().and_then(|_| {
+                self.edit.then_some({
+                    Tooltip::new(
+                        ActionIcon::new("fa fa-times")
+                            .class(css::ColorScheme::Error)
+                            .tabindex(0)
+                            .on_activate({
+                                ctx.link()
+                                    .callback(move |_| Msg::Edit(EditingMessage::Cancel))
+                            }),
+                    )
+                    .tip(tr!("Cancel Editing"))
+                })
+            }))
             .with_child(
                 Tooltip::new(
                     ActionIcon::new("fa fa-cogs")
diff --git a/ui/src/dashboard/view.rs b/ui/src/dashboard/view.rs
index 28fb0158..a39f8f58 100644
--- a/ui/src/dashboard/view.rs
+++ b/ui/src/dashboard/view.rs
@@ -39,6 +39,13 @@ use pdm_client::types::TopEntities;
 mod row_view;
 pub use row_view::RowView;
 
+#[derive(Debug, Clone, PartialEq, Copy)]
+pub enum EditingMessage {
+    Start,
+    Cancel,
+    Finish,
+}
+
 #[derive(Properties, PartialEq)]
 pub struct View {
     view: AttrValue,
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-11-14 12:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 12:11 [pdm-devel] [PATCH datacenter-manager v2 00/18] enable custom views on the UI Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 01/18] lib: pdm-config: views: add locking/saving methods Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 02/18] lib: api-types: add 'layout' property to ViewConfig Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 03/18] server: api: implement CRUD api for views Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 04/18] server: api: resources: add 'view' category to search syntax Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 05/18] ui: remote selector: allow forcing of value Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 06/18] ui: dashboard types: add missing 'default' to de-serialization Dominik Csapak
2025-11-14 12:11 ` Dominik Csapak [this message]
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 08/18] ui: dashboard: prepare view for editing custom views Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 09/18] ui: views: implement view loading from api Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 10/18] ui: views: make 'view' name property optional Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 11/18] ui: views: add 'view' parameter to api calls Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 12/18] ui: views: save updated layout to backend Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 13/18] ui: add view list context Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 14/18] ui: configuration: add view CRUD panels Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 15/18] ui: main menu: add optional view_list property Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 16/18] ui: load view list on page init Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 17/18] lib/ui: move views types to pdm-api-types Dominik Csapak
2025-11-14 12:11 ` [pdm-devel] [PATCH datacenter-manager v2 18/18] server: api: views: check layout string for validity Dominik Csapak
2025-11-14 12:22 ` [pdm-devel] [PATCH datacenter-manager v2 00/18] enable custom views on the UI Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114121218.2479318-8-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal