From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 04/18] server: api: resources: add 'view' category to search syntax
Date: Wed, 12 Nov 2025 17:11:39 +0100 [thread overview]
Message-ID: <20251112161900.75032-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251112161900.75032-1-d.csapak@proxmox.com>
so that we can filter the results by view too.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
server/src/api/resources.rs | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index cdbd90cf..30a4015e 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -60,6 +60,7 @@ enum MatchCategory {
Remote,
RemoteType,
Property,
+ View,
}
impl std::str::FromStr for MatchCategory {
@@ -75,6 +76,7 @@ impl std::str::FromStr for MatchCategory {
"remote" => MatchCategory::Remote,
"remote-type" => MatchCategory::RemoteType,
"property" => MatchCategory::Property,
+ "view" => MatchCategory::View,
_ => bail!("invalid category"),
};
Ok(category)
@@ -105,6 +107,7 @@ impl MatchCategory {
.to_lowercase()
.split(",")
.any(|property| property == search_term.to_lowercase()),
+ MatchCategory::View => true,
}
}
}
@@ -131,6 +134,7 @@ fn resource_matches_search_term(
},
MatchCategory::Remote => category.matches(remote_name, &term.value),
MatchCategory::RemoteType => return None,
+ MatchCategory::View => return None,
},
Some(Err(_)) => false,
None => {
@@ -161,6 +165,7 @@ fn remote_matches_search_term(
MatchCategory::Property => false,
MatchCategory::Template => false,
MatchCategory::RemoteType => category.matches(&remote.ty.to_string(), &term.value),
+ MatchCategory::View => true,
},
Some(Err(_)) => false,
None => {
@@ -316,6 +321,18 @@ pub(crate) async fn get_resources_impl(
let view = views::get_optional_view(view)?;
+ let mut view_filter_from_search = None;
+ filters.matches(|term| {
+ if let Some("view") = term.category.as_deref() {
+ view_filter_from_search = Some(term.value.to_string());
+ }
+ true
+ });
+
+ let view = view.or(views::get_optional_view(
+ view_filter_from_search.as_deref(),
+ )?);
+
let remotes_only = is_remotes_only(&filters);
for (remote_name, remote) in remotes_config {
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-11-12 16:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 16:11 [pdm-devel] [PATCH datacenter-manager 00/18] enable custom views on the UI Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 01/18] lib: pdm-config: views: add locking/saving methods Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 02/18] lib: api-types: add 'layout' property to ViewConfig Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 03/18] server: api: implement CRUD api for views Dominik Csapak
2025-11-12 16:11 ` Dominik Csapak [this message]
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 05/18] ui: remote selector: allow forcing of value Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 06/18] ui: dashboard types: add missing 'default' to de-serialization Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 07/18] ui: dashboard: status row: add optional 'editing state' Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 08/18] ui: dashboard: prepare view for editing custom views Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 09/18] ui: views: implement view loading from api Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 10/18] ui: views: make 'view' name property optional Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 11/18] ui: views: add 'view' parameter to api calls Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 12/18] ui: views: save updated layout to backend Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 13/18] ui: add view list context Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 14/18] ui: configuration: add view CRUD panels Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 15/18] ui: main menu: add optional view_list property Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 16/18] ui: load view list on page init Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 17/18] lib/ui: move views types to pdm-api-types Dominik Csapak
2025-11-12 16:11 ` [pdm-devel] [PATCH datacenter-manager 18/18] server: api: views: check layout string for validity Dominik Csapak
2025-11-14 10:20 ` [pdm-devel] [PATCH datacenter-manager 00/18] enable custom views on the UI Lukas Wagner
2025-11-14 10:56 ` Dominik Csapak
2025-11-14 12:13 ` [pdm-devel] superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112161900.75032-5-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox