[pdm-devel] [PATCH proxmox-datacenter-manager 3/9] ui: improve error message when controller cannot be found

[Gabriel Goller <g.goller@proxmox.com>]

With the added permissions, it often happens that the user has
permissions to view the zone, but doesn't have permissions to view the
controller. This means we can't display the zone in the EVPN overview.
"not found" is a more correct error than "doesn't exist".

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 ui/src/sdn/evpn/remote_tree.rs | 6 ++++--
 ui/src/sdn/evpn/vrf_tree.rs    | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/ui/src/sdn/evpn/remote_tree.rs b/ui/src/sdn/evpn/remote_tree.rs
index ee57b33c18f2..7243a03329c0 100644
--- a/ui/src/sdn/evpn/remote_tree.rs
+++ b/ui/src/sdn/evpn/remote_tree.rs
@@ -176,7 +176,8 @@ fn zones_to_remote_view(
             })
             .ok_or_else(|| {
                 anyhow!(tr!(
-                    "Could not find Controller for EVPN zone {}",
+                    "Controller {} of EVPN zone {} not found",
+                    zone_controller_id,
                     zone_data.zone
                 ))
             })?;
@@ -260,7 +261,8 @@ fn zones_to_remote_view(
             })
             .ok_or_else(|| {
                 anyhow!(tr!(
-                    "Controller of EVPN zone {} does not exist",
+                    "Controller {} of EVPN zone {} not found",
+                    zone_controller_id,
                     zone.zone.zone
                 ))
             })?;
diff --git a/ui/src/sdn/evpn/vrf_tree.rs b/ui/src/sdn/evpn/vrf_tree.rs
index 8481dfcf6027..d690501265a9 100644
--- a/ui/src/sdn/evpn/vrf_tree.rs
+++ b/ui/src/sdn/evpn/vrf_tree.rs
@@ -140,7 +140,8 @@ fn zones_to_vrf_view(
             })
             .ok_or_else(|| {
                 anyhow!(tr!(
-                    "Controller of EVPN zone {} does not exist",
+                    "Controller {} of EVPN zone {} not found",
+                    zone_controller_id,
                     zone_data.zone
                 ))
             })?;
@@ -199,7 +200,8 @@ fn zones_to_vrf_view(
             })
             .ok_or_else(|| {
                 anyhow!(tr!(
-                    "Controller of EVPN zone {} does not exist",
+                    "Controller {} of EVPN zone {} not found",
+                    zone_controller_id,
                     zone.zone.zone
                 ))
             })?;
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel