public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 2/9] api: sdn: rename "vnet" to "controller" in list_controller
Date: Wed, 12 Nov 2025 14:20:19 +0100	[thread overview]
Message-ID: <20251112132045.165444-3-g.goller@proxmox.com> (raw)
In-Reply-To: <20251112132045.165444-1-g.goller@proxmox.com>

Due to a copy-paste error, the result array and error messages were
incorrectly named "vnet". This renames them to "controller" which is
correct.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 server/src/api/sdn/controllers.rs | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/server/src/api/sdn/controllers.rs b/server/src/api/sdn/controllers.rs
index 966125162ef6..e6ab5367792b 100644
--- a/server/src/api/sdn/controllers.rs
+++ b/server/src/api/sdn/controllers.rs
@@ -94,7 +94,7 @@ pub async fn list_controllers(
         None
     });
 
-    let mut vnets = Vec::new();
+    let mut controllers = Vec::new();
     let fetcher = ParallelFetcher::new((pending, running, ty));
 
     let results = fetcher
@@ -111,14 +111,14 @@ pub async fn list_controllers(
                 for (node, node_result) in remote_result.node_results.into_iter() {
                     match node_result {
                         Ok(NodeResults { data, .. }) => {
-                            vnets.extend(data.into_iter().map(|controller| ListController {
+                            controllers.extend(data.into_iter().map(|controller| ListController {
                                 remote: remote.clone(),
                                 controller,
                             }))
                         }
                         Err(error) => {
                             log::error!(
-                                "could not fetch vnets from remote {} node {}: {error:#}",
+                                "could not fetch controllers from remote {} node {}: {error:#}",
                                 remote,
                                 node
                             );
@@ -127,10 +127,13 @@ pub async fn list_controllers(
                 }
             }
             Err(error) => {
-                log::error!("could not fetch vnets from remote {}: {error:#}", remote)
+                log::error!(
+                    "could not fetch controllers from remote {}: {error:#}",
+                    remote
+                )
             }
         }
     }
 
-    Ok(vnets)
+    Ok(controllers)
 }
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-11-12 13:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 13:20 [pdm-devel] [RFC proxmox-datacenter-manager 0/9] Granular permissions for SDN resources Gabriel Goller
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/9] api: sdn: rename vnets to zones in list_zones Gabriel Goller
2025-11-12 13:20 ` Gabriel Goller [this message]
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/9] ui: improve error message when controller cannot be found Gabriel Goller
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 4/9] api: allow acl paths longer than 4 segments in sdn Gabriel Goller
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 5/9] api: sdn: add granular permissions for zones Gabriel Goller
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 6/9] api: sdn: add granular permissions for vnets Gabriel Goller
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 7/9] api: sdn: add granular permissions for controllers Gabriel Goller
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 8/9] api: add permissions for ip-vrf and mac-vrf endpoints Gabriel Goller
2025-11-12 13:20 ` [pdm-devel] [PATCH proxmox-datacenter-manager 9/9] api: add permissions for sdn resources Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112132045.165444-3-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal