public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v4 11/11] pdm-client: top entities: add view parameter
Date: Wed, 12 Nov 2025 11:35:10 +0100	[thread overview]
Message-ID: <20251112103510.158127-12-l.wagner@proxmox.com> (raw)
In-Reply-To: <20251112103510.158127-1-l.wagner@proxmox.com>

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
---
 lib/pdm-client/src/lib.rs | 10 +++++++---
 ui/src/dashboard/view.rs  |  2 +-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs
index 46707e31..9ea0be9b 100644
--- a/lib/pdm-client/src/lib.rs
+++ b/lib/pdm-client/src/lib.rs
@@ -956,9 +956,13 @@ impl<T: HttpApiClient> PdmClient<T> {
         Ok(self.0.get(&path).await?.expect_json()?.data)
     }
 
-    pub async fn get_top_entities(&self) -> Result<TopEntities, Error> {
-        let path = "/api2/extjs/resources/top-entities";
-        Ok(self.0.get(path).await?.expect_json()?.data)
+    pub async fn get_top_entities(&self, view: Option<&str>) -> Result<TopEntities, Error> {
+        let builder = ApiPathBuilder::new("/api2/extjs/resources/top-entities".to_string())
+            .maybe_arg("view", &view);
+
+        let path = builder.build();
+
+        Ok(self.0.get(&path).await?.expect_json()?.data)
     }
 
     pub async fn pve_node_status(&self, remote: &str, node: &str) -> Result<NodeStatus, Error> {
diff --git a/ui/src/dashboard/view.rs b/ui/src/dashboard/view.rs
index c781d991..c973d321 100644
--- a/ui/src/dashboard/view.rs
+++ b/ui/src/dashboard/view.rs
@@ -162,7 +162,7 @@ impl ViewComp {
                     if top_entities {
                         let client: pdm_client::PdmClient<Rc<proxmox_yew_comp::HttpClientWasm>> =
                             pdm_client();
-                        let res = client.get_top_entities().await;
+                        let res = client.get_top_entities(None).await;
                         link.send_message(Msg::LoadingResult(LoadingResult::TopEntities(res)));
                     }
                 };
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

  parent reply	other threads:[~2025-11-12 10:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 10:34 [pdm-devel] [PATCH datacenter-manager v4 00/11] backend implementation for view filters Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 01/11] pdm-api-types: views: add ViewConfig type Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 02/11] pdm-config: views: add support for views Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 03/11] acl: add '/view' and '/view/{view-id}' as allowed ACL paths Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 04/11] views: add implementation for view resource filtering Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 05/11] api: resources: list: add support for view parameter Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 06/11] api: resources: top entities: " Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 07/11] api: resources: status: " Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 08/11] api: subscription " Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 09/11] api: remote-tasks: " Lukas Wagner
2025-11-12 10:35 ` [pdm-devel] [PATCH datacenter-manager v4 10/11] pdm-client: resource list: add " Lukas Wagner
2025-11-12 10:35 ` Lukas Wagner [this message]
2025-11-13 12:19 ` [pdm-devel] superseded: [PATCH datacenter-manager v4 00/11] backend implementation for view filters Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112103510.158127-12-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal