From: Fiona Ebner <f.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/1] buildsys: initialize pwt-assets as submodule automatically
Date: Wed, 29 Oct 2025 15:14:03 +0100 [thread overview]
Message-ID: <20251029141559.142782-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20251029141559.142782-1-f.ebner@proxmox.com>
When the submodule is not initialized there would be some errors at
the beginning of the build like:
> Error: Can't find stylesheet to import.
but then cargo would continue and compile everything only for the
build to fail at the very end.
Copied from Stoiko's equivalent patch for PMG [0].
[0]: https://lore.proxmox.com/pmg-devel/20251028163628.79739-2-s.ivanov@proxmox.com/
Co-developed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
By chance, I stumbled upon Stoiko's patch for PMG after running into
the issue myself in PDM :)
ui/Makefile | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui/Makefile b/ui/Makefile
index 61e5c77..49ae8ee 100644
--- a/ui/Makefile
+++ b/ui/Makefile
@@ -75,8 +75,11 @@ install: $(COMPILED_OUTPUT) index.hbs
install -m0644 dist/material-yew-style.css $(DESTDIR)$(UIDIR)
install -m0644 dist/desktop-yew-style.css $(DESTDIR)$(UIDIR)
+.PHONY: submodule
+submodule:
+ test -f "pwt-assets/README.md" || git submodule update --init
-$(BUILDDIR):
+$(BUILDDIR): submodule
rm -rf $@ $@.tmp
mkdir -p $@.tmp/ui
cp -a debian/ src/ pwt-assets/ images/ css/ index.hbs Makefile Cargo.toml $@.tmp/ui
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-10-29 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 14:14 [pdm-devel] [PATCH datacenter-manager 0/1] " Fiona Ebner
2025-10-29 14:14 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029141559.142782-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox