public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel
Date: Wed, 29 Oct 2025 11:09:58 +0100	[thread overview]
Message-ID: <20251029100958.309086-1-c.ebner@proxmox.com> (raw)

The PBS datastore panel currently mixes status information
(maintenance, usage, ...) with datastore properties (removable, s3).
Since the latter will not change, and the dashboard panels are more
intended to show current status information, drop the removable and
s3 columns. The search filters remain unaffected by this, still
allowing to filter PBS datastored by these.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 ui/src/dashboard/pbs_datastores_panel.rs | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
index 3e148e6..a06acf7 100644
--- a/ui/src/dashboard/pbs_datastores_panel.rs
+++ b/ui/src/dashboard/pbs_datastores_panel.rs
@@ -40,8 +40,6 @@ impl From<PbsDatastoresPanel> for VNode {
 pub enum StatusRow {
     Online(u64),
     UnderMaintenance(u64),
-    Removable(u64),
-    S3Backend(u64),
     HighUsage(u64),
     Unknown(u64),
     All(u64),
@@ -75,8 +73,6 @@ impl yew::Component for PbsDatastoresPanelComponent {
         let data = vec![
             StatusRow::Online(status.online),
             StatusRow::UnderMaintenance(status.under_maintenance.unwrap_or_default()),
-            StatusRow::Removable(status.removable.unwrap_or_default()),
-            StatusRow::S3Backend(status.s3_backend.unwrap_or_default()),
             StatusRow::HighUsage(status.high_usage.unwrap_or_default()),
             StatusRow::Unknown(status.unknown.unwrap_or_default()),
             StatusRow::All(status.online + status.under_maintenance.unwrap_or_default()),
@@ -121,18 +117,6 @@ fn create_list_tile(
             "Under Maintenance",
             Some(("under-maintenance", "status")),
         ),
-        StatusRow::Removable(count) => (
-            Fa::new("plug"),
-            count,
-            "Removable",
-            Some(("removable", "property")),
-        ),
-        StatusRow::S3Backend(count) => (
-            Fa::new("cloud-upload"),
-            count,
-            "S3",
-            Some(("s3", "property")),
-        ),
         StatusRow::Unknown(count) => (
             Fa::from(Status::Unknown),
             count,
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-10-29 10:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 10:09 Christian Ebner [this message]
2025-10-29 14:06 ` Wolfgang Bumiller
2025-10-29 14:12   ` Christian Ebner
2025-10-29 15:15     ` Wolfgang Bumiller
2025-10-29 19:34       ` Thomas Lamprecht
2025-10-29 15:15 ` [pdm-devel] applied: " Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029100958.309086-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal