From: Dietmar Maurer <dietmar@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 4/4] ui: qemu: remove wrong PartialEq implementation
Date: Wed, 15 Oct 2025 10:15:24 +0200 [thread overview]
Message-ID: <20251015081524.2863240-4-dietmar@proxmox.com> (raw)
In-Reply-To: <20251015081524.2863240-1-dietmar@proxmox.com>
i.e. we want to update the view on cpu property changes.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
ui/src/pve/qemu/overview.rs | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/ui/src/pve/qemu/overview.rs b/ui/src/pve/qemu/overview.rs
index 62efbae..3d715eb 100644
--- a/ui/src/pve/qemu/overview.rs
+++ b/ui/src/pve/qemu/overview.rs
@@ -17,7 +17,7 @@ use pdm_client::types::{IsRunning, QemuStatus};
use crate::renderer::{separator, status_row};
-#[derive(Clone, Debug, Properties)]
+#[derive(Clone, Debug, Properties, PartialEq)]
pub struct QemuOverviewPanel {
remote: String,
node: String,
@@ -32,20 +32,6 @@ pub struct QemuOverviewPanel {
pub status_interval: u32,
}
-impl PartialEq for QemuOverviewPanel {
- fn eq(&self, other: &Self) -> bool {
- if self.remote == other.remote && self.node == other.node {
- // only check some fields, so we don't update when e.g. only the cpu changes
- self.info.name == other.info.name
- && self.info.id == other.info.id
- && self.info.node == other.node
- } else {
- false
- }
- }
-}
-impl Eq for QemuOverviewPanel {}
-
impl QemuOverviewPanel {
pub fn new(remote: String, node: String, info: PveQemuResource) -> Self {
yew::props!(Self { remote, node, info })
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-10-15 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 8:15 [pdm-devel] [PATCH datacenter-manager 1/4] ui: qemu: move files into subfolder, add Tabbar on top Dietmar Maurer
2025-10-15 8:15 ` [pdm-devel] [PATCH datacenter-manager 2/4] ui: qemu: cleanup: use module level imports Dietmar Maurer
2025-10-15 8:15 ` [pdm-devel] [PATCH datacenter-manager 3/4] ui: qemu: cleanup: avoid "use pwt::css::XYZ" imports Dietmar Maurer
2025-10-15 8:15 ` Dietmar Maurer [this message]
2025-10-16 22:17 ` [pdm-devel] [PATCH datacenter-manager 1/4] ui: qemu: move files into subfolder, add Tabbar on top Thomas Lamprecht
2025-10-22 5:18 ` [pdm-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015081524.2863240-4-dietmar@proxmox.com \
--to=dietmar@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox