[pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility

[Christian Ebner <c.ebner@proxmox.com>]

This patches fix the ticket parsing when login to instances of PBS version 3
or lower. For this, the current pve_compat flags for `Login` and `Client`
are refactored to be an extendable enum variant instead, adding the ticket
parsing backwards compatibility. In that compatibility mode, response parsing
of the ticket does not interpret the presence of the `ticket-info` field as the
ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4
compatible parsing, as the client never used `http-only` tickets.

Since this fixes token generation and ACLs setting via the remote add wizard,
revert the now outdated warning of PBS v4 minimum requirement.

Changes since version 1:
- Fix check for CompatMode::Pbs3Ticket in response ticket parsing, must skip the
  http-only path.
- Set the compatibility mode on the client, not the login. The client propagates
  the compat mode to the login on login() calls. Since that incorrectly set the
  state, the PBS logic worked nevertheless during testing, but also affected the
  PVE state, which was not intended.

proxmox:

Christian Ebner (3):
  proxmox-login: refactor PVE TFA compat mode
  proxmox-client: adapt to new compat mode introduced for proxmox-login
  proxmox-login: add compat mode to fallback to PBS3 ticket parsing

 proxmox-client/src/client.rs | 12 ++++----
 proxmox-client/src/lib.rs    |  2 +-
 proxmox-login/src/lib.rs     | 55 +++++++++++++++++++++++++-----------
 3 files changed, 45 insertions(+), 24 deletions(-)


datacenter-manager:

Christian Ebner (3):
  server: adapt to proxmox-client compat mode changes
  server: pbs-client: check and fallback to PBS v3 ticket compat mode
  Revert "ui: add wizard: note that login currently only works for PBS
    4"

 server/src/connection.rs           | 31 +++++++++++++++++++-----------
 ui/src/remotes/wizard_page_info.rs | 15 ---------------
 2 files changed, 20 insertions(+), 26 deletions(-)


Summary over all repositories:
  5 files changed, 65 insertions(+), 50 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel