public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager/proxmox 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility
Date: Mon, 29 Sep 2025 17:48:14 +0200	[thread overview]
Message-ID: <20250929154820.892720-1-c.ebner@proxmox.com> (raw)

This patches fix the ticket parsing when login to instances of PBS version 3
or lower. For this, the current pve_compat flags for `Login` and `Client`
are refactored to be an extendable enum variant instead, adding the ticket
parsing backwards compatibility. In that compatibility mode, response parsing
of the ticket does not interpret the presence of the `ticket-info` field as the
ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4
compatible parsing, as the client never used `http-only` tickets.

Since this fixes token generation and ACLs setting via the remote add wizard,
revert the now outdated warning of PBS v4 minimum requirement.

proxmox:

Christian Ebner (3):
  proxmox-login: refactor PVE TFA compat mode
  proxmox-client: adapt to new compat mode introduced for proxmox-login
  proxmox-login: add compat mode to fallback to PBS3 ticket parsing

 proxmox-client/src/client.rs | 12 ++++----
 proxmox-client/src/lib.rs    |  2 +-
 proxmox-login/src/lib.rs     | 55 +++++++++++++++++++++++++-----------
 3 files changed, 45 insertions(+), 24 deletions(-)


datacenter-manager:

Christian Ebner (3):
  server: adapt to proxmox-client compat mode changes
  server: pbs-client: check and fallback to PBS v3 ticket compat mode
  Revert "ui: add wizard: note that login currently only works for PBS
    4"

 server/src/connection.rs           | 43 +++++++++++++++++-------------
 ui/src/remotes/wizard_page_info.rs | 15 -----------
 2 files changed, 25 insertions(+), 33 deletions(-)


Summary over all repositories:
  5 files changed, 70 insertions(+), 57 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-09-29 15:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29 15:48 Christian Ebner [this message]
2025-09-29 15:48 ` [pdm-devel] [PATCH proxmox 1/3] proxmox-login: refactor PVE TFA compat mode Christian Ebner
2025-09-29 15:48 ` [pdm-devel] [PATCH proxmox 2/3] proxmox-client: adapt to new compat mode introduced for proxmox-login Christian Ebner
2025-09-29 15:48 ` [pdm-devel] [PATCH proxmox 3/3] proxmox-login: add compat mode to fallback to PBS3 ticket parsing Christian Ebner
2025-09-29 18:01   ` Christian Ebner
2025-09-29 15:48 ` [pdm-devel] [PATCH datacenter-manager 1/3] server: adapt to proxmox-client compat mode changes Christian Ebner
2025-09-29 15:48 ` [pdm-devel] [PATCH datacenter-manager 2/3] server: pbs-client: check and fallback to PBS v3 ticket compat mode Christian Ebner
2025-09-29 15:48 ` [pdm-devel] [PATCH datacenter-manager 3/3] Revert "ui: add wizard: note that login currently only works for PBS 4" Christian Ebner
2025-09-30  8:03 ` [pdm-devel] superseded: [PATCH datacenter-manager/proxmox 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250929154820.892720-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal