public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp 4/8] meter label: use `StatusRow` for text row
Date: Tue, 23 Sep 2025 11:51:07 +0200	[thread overview]
Message-ID: <20250923095124.1679038-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250923095124.1679038-1-d.csapak@proxmox.com>

it's already almost identical, so let's reuse it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/meter_label.rs | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/src/meter_label.rs b/src/meter_label.rs
index c4ef22f..1e92dca 100644
--- a/src/meter_label.rs
+++ b/src/meter_label.rs
@@ -1,10 +1,12 @@
 use yew::html::IntoPropValue;
 
 use pwt::prelude::*;
-use pwt::widget::{Container, Meter, Row};
+use pwt::widget::{Container, Meter};
 
 use pwt_macros::{builder, widget};
 
+use crate::StatusRow;
+
 #[widget(comp=ProxmoxMeterLabel, @element)]
 #[derive(Properties, Clone, PartialEq)]
 #[builder]
@@ -108,12 +110,6 @@ impl Component for ProxmoxMeterLabel {
     fn view(&self, ctx: &Context<Self>) -> Html {
         let props = ctx.props();
 
-        let icon = props.icon_class.as_ref().map(|icon_class| {
-            Container::from_tag("i")
-                .class(icon_class.clone())
-                .padding_end(2)
-        });
-
         let status = match &props.status {
             Some(text) => text.clone(),
             None => match props.value {
@@ -122,13 +118,9 @@ impl Component for ProxmoxMeterLabel {
             },
         };
 
-        let text_row = Row::new()
-            .gap(2)
-            .with_child(
-                html! {<div class="pwt-white-space-nowrap">{icon}{props.title.clone()}</div>},
-            )
-            .with_flex_spacer()
-            .with_child(html! {<div class="pwt-white-space-nowrap">{status}</div>});
+        let text_row = StatusRow::new(props.title.clone())
+            .status(status)
+            .icon_class(props.icon_class.clone());
 
         Container::new()
             .with_std_props(&props.std_props)
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-09-23  9:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23  9:51 [pdm-devel] [PATCH datacenter-manager/yew-comp 00/10] status row/node status cleanup + refactor Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH yew-comp 1/8] status: impl conversion to classes Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH yew-comp 2/8] status row: add option to add the icon on the right side Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH yew-comp 3/8] meter label: make value optional Dominik Csapak
2025-09-23  9:51 ` Dominik Csapak [this message]
2025-09-23  9:51 ` [pdm-devel] [PATCH yew-comp 5/8] meter label: align the status row with baseline Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH yew-comp 6/8] meter label: add `animated` property Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH yew-comp 7/8] meter label: add option to align the icon on the right Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH yew-comp 8/8] add `node_info` helper to render a consistent view of the NodeStatus Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH datacenter-manager 1/2] ui: pve: node: use `node_info` helper from yew-comp Dominik Csapak
2025-09-23  9:51 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: rework status row/meter helpers Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250923095124.1679038-5-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal