From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp 3/8] meter label: make value optional
Date: Tue, 23 Sep 2025 11:51:06 +0200 [thread overview]
Message-ID: <20250923095124.1679038-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250923095124.1679038-1-d.csapak@proxmox.com>
If there is no value given, just omit the Meter, so it's behaving like a
`StatusRow`. This can come in handy in situations where we use both
`StatusRow` and `MeterLabel` but want to abstract the specific
configuration away.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/meter_label.rs | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/meter_label.rs b/src/meter_label.rs
index 5b9e843..c4ef22f 100644
--- a/src/meter_label.rs
+++ b/src/meter_label.rs
@@ -56,9 +56,9 @@ pub struct MeterLabel {
/// specified, but not within the range given by the min attribute
/// and max attribute, the value is equal to the nearest end of
/// the range.
- #[prop_or(0f32)]
- #[builder]
- pub value: f32,
+ #[prop_or_default]
+ #[builder(IntoPropValue, into_prop_value)]
+ pub value: Option<f32>,
#[prop_or_default]
pub status: Option<Html>,
@@ -116,7 +116,10 @@ impl Component for ProxmoxMeterLabel {
let status = match &props.status {
Some(text) => text.clone(),
- None => html! {format!("{:.2} %", props.value * 100.0)},
+ None => match props.value {
+ Some(value) => html! {format!("{:.2} %", value * 100.0)},
+ None => html! {},
+ },
};
let text_row = Row::new()
@@ -131,16 +134,16 @@ impl Component for ProxmoxMeterLabel {
.with_std_props(&props.std_props)
.listeners(&props.listeners)
.with_child(text_row)
- .with_child(
+ .with_optional_child(props.value.map(|value| {
Meter::new()
.margin_top(1)
- .value(props.value)
+ .value(value)
.min(props.min)
.max(props.max)
.low(props.low)
.high(props.high)
- .optimum(props.optimum),
- )
+ .optimum(props.optimum)
+ }))
.into()
}
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-23 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 9:51 [pdm-devel] [PATCH datacenter-manager/yew-comp 00/10] status row/node status cleanup + refactor Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 1/8] status: impl conversion to classes Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 2/8] status row: add option to add the icon on the right side Dominik Csapak
2025-09-23 9:51 ` Dominik Csapak [this message]
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 4/8] meter label: use `StatusRow` for text row Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 5/8] meter label: align the status row with baseline Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 6/8] meter label: add `animated` property Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 7/8] meter label: add option to align the icon on the right Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 8/8] add `node_info` helper to render a consistent view of the NodeStatus Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH datacenter-manager 1/2] ui: pve: node: use `node_info` helper from yew-comp Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: rework status row/meter helpers Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923095124.1679038-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox