From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp 2/8] status row: add option to add the icon on the right side
Date: Tue, 23 Sep 2025 11:51:05 +0200 [thread overview]
Message-ID: <20250923095124.1679038-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250923095124.1679038-1-d.csapak@proxmox.com>
This is sometimes better than showing it always on the left side.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/status_row.rs | 36 ++++++++++++++++++++++++++++--------
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/src/status_row.rs b/src/status_row.rs
index fe64127..8eda9b7 100644
--- a/src/status_row.rs
+++ b/src/status_row.rs
@@ -15,6 +15,9 @@ pub struct StatusRow {
#[prop_or_default]
pub status: Option<Html>,
+
+ #[prop_or_default]
+ pub icon_right: bool,
}
impl StatusRow {
@@ -41,6 +44,17 @@ impl StatusRow {
self.status = Some(status.into());
self
}
+
+ /// Method to control which side the icon should go on.
+ pub fn set_icon_right(&mut self, icon_right: impl Into<bool>) {
+ self.icon_right = icon_right.into();
+ }
+
+ /// Builder style method to control which side the icon should go on.
+ pub fn icon_right(mut self, icon_right: impl Into<bool>) -> Self {
+ self.set_icon_right(icon_right);
+ self
+ }
}
#[doc(hidden)]
@@ -57,11 +71,17 @@ impl Component for ProxmoxStatusRow {
fn view(&self, ctx: &Context<Self>) -> Html {
let props = ctx.props();
- let icon = props.icon_class.as_ref().map(|icon_class| {
- Container::from_tag("i")
- .class(icon_class.clone())
- .padding_end(2)
- });
+ let (left_icon, right_icon) = match &props.icon_class {
+ Some(icon_class) => {
+ let icon = Container::from_tag("i").class(icon_class.clone());
+ if props.icon_right {
+ (None, Some(icon))
+ } else {
+ (Some(icon), None)
+ }
+ }
+ None => (None, None),
+ };
let status = match &props.status {
Some(text) => text.clone(),
@@ -73,11 +93,11 @@ impl Component for ProxmoxStatusRow {
.class(Display::Flex) // we need to set this again
.listeners(&props.listeners)
.gap(2)
- .with_child(
- html! {<div class="pwt-white-space-nowrap">{icon}{props.title.clone()}</div>},
- )
+ .with_optional_child(left_icon)
+ .with_child(html! {<div class="pwt-white-space-nowrap">{props.title.clone()}</div>})
.with_flex_spacer()
.with_child(html! {<div class="pwt-white-space-nowrap">{status}</div>})
+ .with_optional_child(right_icon)
.into()
}
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-23 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 9:51 [pdm-devel] [PATCH datacenter-manager/yew-comp 00/10] status row/node status cleanup + refactor Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 1/8] status: impl conversion to classes Dominik Csapak
2025-09-23 9:51 ` Dominik Csapak [this message]
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 3/8] meter label: make value optional Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 4/8] meter label: use `StatusRow` for text row Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 5/8] meter label: align the status row with baseline Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 6/8] meter label: add `animated` property Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 7/8] meter label: add option to align the icon on the right Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 8/8] add `node_info` helper to render a consistent view of the NodeStatus Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH datacenter-manager 1/2] ui: pve: node: use `node_info` helper from yew-comp Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: rework status row/meter helpers Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923095124.1679038-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox