From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager/yew-comp 00/10] status row/node status cleanup + refactor
Date: Tue, 23 Sep 2025 11:51:03 +0200 [thread overview]
Message-ID: <20250923095124.1679038-1-d.csapak@proxmox.com> (raw)
While implemnting some basic PBS panels, i stumbled over our reimplemntation
of the already existing `MeterLabel` and `StatusRow` from proxmox-yew-comp.
So this series should improve on that by reusing them.
Also refactored the panel for the NodeStatus in a way that we can reuse
it for PBS as well and at the same time make it more conform to what we already
have in the 'native' PVE/PBS gui.
Note that the pdm patches depend on the yew-comp patches, so a bump is
necessary
also i based this series on top of my other two patches[0]
(but they should not interfere with each other)
0: https://lore.proxmox.com/pdm-devel/20250923094311.1612890-1-d.csapak@proxmox.com/T/#t
proxmox-yew-comp:
Dominik Csapak (8):
status: impl conversion to classes
status row: add option to add the icon on the right side
meter label: make value optional
meter label: use `StatusRow` for text row
meter label: align the status row with baseline
meter label: add `animated` property
meter label: add option to align the icon on the right
add `node_info` helper to render a consistent view of the NodeStatus
Cargo.toml | 3 +
src/lib.rs | 3 +
src/meter_label.rs | 53 ++++++-----
src/node_info.rs | 222 +++++++++++++++++++++++++++++++++++++++++++++
src/status.rs | 8 ++
src/status_row.rs | 36 ++++++--
6 files changed, 295 insertions(+), 30 deletions(-)
create mode 100644 src/node_info.rs
proxmox-datacenter-manager:
Dominik Csapak (2):
ui: pve: node: use `node_info` helper from yew-comp
ui: rework status row/meter helpers
ui/src/pve/lxc.rs | 48 ++++++++---------
ui/src/pve/node/overview.rs | 76 +++-----------------------
ui/src/pve/qemu.rs | 48 ++++++++---------
ui/src/pve/remote.rs | 103 +++++++++++++++++-------------------
ui/src/pve/storage.rs | 55 +++++++++----------
ui/src/renderer.rs | 63 +++++++---------------
6 files changed, 145 insertions(+), 248 deletions(-)
Summary over all repositories:
12 files changed, 440 insertions(+), 278 deletions(-)
--
Generated by git-murpp 0.8.1
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-09-23 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 9:51 Dominik Csapak [this message]
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 1/8] status: impl conversion to classes Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 2/8] status row: add option to add the icon on the right side Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 3/8] meter label: make value optional Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 4/8] meter label: use `StatusRow` for text row Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 5/8] meter label: align the status row with baseline Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 6/8] meter label: add `animated` property Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 7/8] meter label: add option to align the icon on the right Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH yew-comp 8/8] add `node_info` helper to render a consistent view of the NodeStatus Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH datacenter-manager 1/2] ui: pve: node: use `node_info` helper from yew-comp Dominik Csapak
2025-09-23 9:51 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: rework status row/meter helpers Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923095124.1679038-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox