From: Shannon Sterz <s.sterz@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp v2 5/6] auth_view: implement syncing ldap and ad realms
Date: Mon, 22 Sep 2025 17:05:12 +0200 [thread overview]
Message-ID: <20250922150519.399573-7-s.sterz@proxmox.com> (raw)
In-Reply-To: <20250922150519.399573-1-s.sterz@proxmox.com>
by adding an EditWindow that allows specifying the sync options and
then calling the specified sync endpoint.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
src/auth_view.rs | 155 +++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 151 insertions(+), 4 deletions(-)
diff --git a/src/auth_view.rs b/src/auth_view.rs
index a70e80b..f957e65 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -4,6 +4,9 @@ use std::rc::Rc;
use anyhow::Error;
+use proxmox_client::ApiResponseData;
+use pwt::widget::form::{Checkbox, FormContext, TristateBoolean};
+use serde_json::Value;
use yew::html::IntoPropValue;
use yew::virtual_dom::{VComp, VNode};
@@ -12,13 +15,13 @@ use pwt::state::{Selection, Store};
use pwt::widget::data_table::{DataTable, DataTableColumn, DataTableHeader};
use pwt::widget::menu::{Menu, MenuButton, MenuItem};
-use pwt::widget::{Button, Fa, Toolbar};
+use pwt::widget::{Button, Container, Fa, InputPanel, Toolbar};
use pwt_macros::builder;
use crate::{
- AuthEditLDAP, AuthEditOpenID, LoadableComponent, LoadableComponentContext,
- LoadableComponentMaster,
+ AuthEditLDAP, AuthEditOpenID, EditWindow, LoadableComponent, LoadableComponentContext,
+ LoadableComponentLink, LoadableComponentMaster,
};
use crate::common_api_types::BasicRealmInfo;
@@ -69,6 +72,7 @@ pub enum ViewState {
EditOpenID(AttrValue),
EditLDAP(AttrValue),
EditAd(AttrValue),
+ Sync(BasicRealmInfo),
}
pub enum Msg {
@@ -89,6 +93,73 @@ async fn delete_item(base_url: AttrValue, realm: AttrValue) -> Result<(), Error>
Ok(())
}
+async fn sync_realm(
+ form_ctx: FormContext,
+ link: LoadableComponentLink<ProxmoxAuthView>,
+ url: impl Into<String>,
+) -> Result<(), Error> {
+ let mut data = form_ctx.get_submit_data();
+
+ let mut remove_vanished = Vec::new();
+
+ for prop in ["acl", "entry", "properties"] {
+ let prop_name = format!("remove-vanished-{prop}");
+ if data[&prop_name] == Value::Bool(true) {
+ remove_vanished.push(prop);
+ }
+
+ data[&prop_name] = Value::Null;
+ }
+
+ if !remove_vanished.is_empty() {
+ data["remove-vanished"] = Value::String(remove_vanished.join(";"));
+ }
+
+ let mut new = serde_json::json!({});
+
+ for (param, v) in data.as_object().unwrap().iter() {
+ if !v.is_null() {
+ new[param] = v.clone();
+ }
+ }
+
+ match crate::http_post::<String>(url, Some(new)).await {
+ Ok(upid) => link.show_task_log(upid, None),
+ Err(err) => link.show_error(tr!("Sync Failed"), err, true),
+ };
+
+ Ok(())
+}
+
+async fn load_realm(url: impl Into<String>) -> Result<ApiResponseData<Value>, Error> {
+ let mut response: ApiResponseData<Value> = crate::http_get_full(url, None).await?;
+
+ if let Value::String(sync_default_options) = response.data["sync-defaults-options"].take() {
+ let split = sync_default_options.split(",");
+
+ for part in split {
+ let mut part = part.split("=");
+
+ match part.next() {
+ Some("enable-new") => {
+ response.data["enable-new"] = Value::Bool(part.next() == Some("true"))
+ }
+ Some("remove-vanished") => {
+ if let Some(part) = part.next() {
+ for vanished_opt in part.split(";") {
+ response.data[&format!("remove-vanished-{vanished_opt}")] =
+ Value::Bool(true)
+ }
+ }
+ }
+ _ => {}
+ }
+ }
+ }
+
+ Ok(response)
+}
+
impl ProxmoxAuthView {
fn get_selected_record(&self) -> Option<BasicRealmInfo> {
let selected_key = self.selection.selected_key();
@@ -171,7 +242,12 @@ impl LoadableComponent for ProxmoxAuthView {
true
}
Msg::Sync => {
- // fixme: do something
+ let info = match self.get_selected_record() {
+ Some(info) => info,
+ None => return true,
+ };
+
+ ctx.link().change_view(Some(ViewState::Sync(info)));
true
}
}
@@ -312,6 +388,77 @@ impl LoadableComponent for ProxmoxAuthView {
.on_close(ctx.link().change_view_callback(|_| None))
.into(),
),
+ ViewState::Sync(realm) => {
+ let link = ctx.link();
+ let url = format!(
+ "{}/{}/sync",
+ ctx.props().base_url,
+ percent_encode_component(&realm.realm)
+ );
+
+ let base_url = match realm.ty.as_str() {
+ // unwraps here are safe as the guards ensure the Option is a Some
+ "ldap" if props.ldap_base_url.is_some() => {
+ props.ldap_base_url.as_ref().unwrap()
+ }
+ "ad" if props.ad_base_url.is_some() => props.ad_base_url.as_ref().unwrap(),
+ _ => return None,
+ };
+
+ Some(
+ EditWindow::new(tr!("Realm Sync"))
+ .renderer(|_form_ctx| {
+ InputPanel::new()
+ .padding(4)
+ .with_field(tr!("Preview Only"), Checkbox::new().name("dry-run"))
+ .with_field(
+ tr!("Enable new users"),
+ TristateBoolean::new()
+ .name("enable-new")
+ .null_text(tr!("Default") + " (" + &tr!("Yes") + ")"),
+ )
+ .with_large_custom_child(
+ Container::new()
+ .key("remove-vanished-options")
+ .class("pwt-font-title-medium")
+ .padding_top(2)
+ .with_child(tr!("Remove Vanished Options")),
+ )
+ .with_large_field(
+ tr!("ACLs"),
+ Checkbox::new()
+ .name("remove-vanished-acl")
+ .box_label(tr!("Remove ACLs of vanished users.")),
+ )
+ .with_large_field(
+ tr!("Entries"),
+ Checkbox::new()
+ .name("remove-vanished-entry")
+ .box_label(tr!("Remove vanished user")),
+ )
+ .with_large_field(
+ tr!("Properties"),
+ Checkbox::new()
+ .name("remove-vanished-properties")
+ .box_label(tr!("Remove vanished properties")),
+ )
+ .into()
+ })
+ .loader({
+ let url =
+ format!("{base_url}/{}", percent_encode_component(&realm.realm));
+ move || load_realm(url.clone())
+ })
+ .submit_digest(false)
+ .on_close(link.change_view_callback(|_| None))
+ .on_submit(move |form_context| {
+ let link = link.clone();
+ let url = url.clone();
+ sync_realm(form_context, link, url)
+ })
+ .into(),
+ )
+ }
}
}
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-22 15:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 15:05 [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp v2 00/13] Add LDAP and AD realm support to Proxmox Datacenter Manager Shannon Sterz
2025-09-22 15:05 ` [pdm-devel] [PATCH proxmox v2 1/1] ldap: add types and sync features Shannon Sterz
2025-09-22 18:28 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 1/6] auth_view: add default column and allow setting ldap realms as default Shannon Sterz
2025-09-22 19:00 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 2/6] utils: add pdm realm to `get_auth_domain_info` Shannon Sterz
2025-09-22 19:00 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 3/6] auth_view/auth_edit_ldap: add support for active directory realms Shannon Sterz
2025-09-22 19:00 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 4/6] auth_edit_ldap: add helpers to properly edit ad & ldap realms Shannon Sterz
2025-09-22 19:00 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` Shannon Sterz [this message]
2025-09-22 19:00 ` [pdm-devel] applied: [PATCH yew-comp v2 5/6] auth_view: implement syncing ldap and ad realms Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 6/6] auth_edit_ldap: improve form layout and placeholders Shannon Sterz
2025-09-22 19:00 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 1/6] config: add domain config plugins for ldap and ad realms Shannon Sterz
2025-09-22 19:03 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 2/6] server: add ldap and active directory authenticators Shannon Sterz
2025-09-22 19:03 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 3/6] server: api: add api endpoints for configuring ldap & ad realms Shannon Sterz
2025-09-22 19:03 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 4/6] api/auth: add endpoint to start ldap sync jobs Shannon Sterz
2025-09-22 19:03 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 5/6] ui: add a panel to allow handling realms Shannon Sterz
2025-09-22 19:03 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 6/6] ui: make the user tab reload when re-opened Shannon Sterz
2025-09-22 19:03 ` [pdm-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922150519.399573-7-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox