From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 6/6] ui: reorganize remote add button as dropdown menu to allow adding PBS
Date: Mon, 22 Sep 2025 13:09:58 +0200 [thread overview]
Message-ID: <20250922110958.369653-7-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250922110958.369653-1-c.ebner@proxmox.com>
Already implemented, just switch out the code in the comment with the
current one.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
ui/src/remotes/config.rs | 42 +++++++++++++++++-----------------------
1 file changed, 18 insertions(+), 24 deletions(-)
diff --git a/ui/src/remotes/config.rs b/ui/src/remotes/config.rs
index db5646b..7efc6e8 100644
--- a/ui/src/remotes/config.rs
+++ b/ui/src/remotes/config.rs
@@ -25,7 +25,7 @@ use pwt::state::{Selection, Store};
use pwt::widget::data_table::{DataTable, DataTableColumn, DataTableHeader};
//use pwt::widget::form::{delete_empty_values, Field, FormContext, InputType};
use pwt::widget::{
- //menu::{Menu, MenuButton, MenuItem},
+ menu::{Menu, MenuButton, MenuItem},
Button,
Column,
Toolbar,
@@ -173,29 +173,23 @@ impl LoadableComponent for PbsRemoteConfigPanel {
.class("pwt-overflow-hidden")
.class("pwt-border-bottom")
.with_child({
- Button::new(tr!("Add Proxmox VE"))
- .icon_class("fa fa-building")
- .on_activate(
- link.change_view_callback(|_| Some(ViewState::Add(RemoteType::Pve))),
- )
- // FIXME: add PBS support
- //MenuButton::new(tr!("Add")).show_arrow(true).menu(
- // Menu::new()
- // .with_item(
- // MenuItem::new("Proxmox VE")
- // .icon_class("fa fa-building")
- // .on_select(link.change_view_callback(|_| {
- // Some(ViewState::Add(RemoteType::Pve))
- // })),
- // )
- // .with_item(
- // MenuItem::new("Proxmox Backup Server")
- // .icon_class("fa fa-floppy-o")
- // .on_select(link.change_view_callback(|_| {
- // Some(ViewState::Add(RemoteType::Pbs))
- // })),
- // ),
- //)
+ MenuButton::new(tr!("Add")).show_arrow(true).menu(
+ Menu::new()
+ .with_item(
+ MenuItem::new("Proxmox VE")
+ .icon_class("fa fa-building")
+ .on_select(link.change_view_callback(|_| {
+ Some(ViewState::Add(RemoteType::Pve))
+ })),
+ )
+ .with_item(
+ MenuItem::new("Proxmox Backup Server")
+ .icon_class("fa fa-floppy-o")
+ .on_select(link.change_view_callback(|_| {
+ Some(ViewState::Add(RemoteType::Pbs))
+ })),
+ ),
+ )
})
.with_spacer()
.with_child(
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-22 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 11:09 [pdm-devel] [PATCH datacenter-manager 0/6] ui/api: implement and expose adding PBS remotes via the ui wizard Christian Ebner
2025-09-22 11:09 ` [pdm-devel] [PATCH datacenter-manager 1/6] server: api: add TLS probe endpoint for PBS Christian Ebner
2025-09-22 11:09 ` [pdm-devel] [PATCH datacenter-manager 2/6] pdm-client: add method to probe TLS connection for PBS remotes Christian Ebner
2025-09-22 11:09 ` [pdm-devel] [PATCH datacenter-manager 3/6] server: api: implement endpoint to scan remote PBS instances Christian Ebner
2025-09-22 11:09 ` [pdm-devel] [PATCH datacenter-manager 4/6] pdm client: add method " Christian Ebner
2025-09-22 11:09 ` [pdm-devel] [PATCH datacenter-manager 5/6] ui: remote: check connection for PBS remotes in remote add wizard Christian Ebner
2025-09-22 11:09 ` Christian Ebner [this message]
2025-09-22 12:50 ` [pdm-devel] [PATCH datacenter-manager 0/6] ui/api: implement and expose adding PBS remotes via the ui wizard Lukas Wagner
2025-09-22 12:56 ` Christian Ebner
2025-09-22 17:59 ` [pdm-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922110958.369653-7-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox