public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/2] server: api: resources: implement remote match for template
Date: Wed, 10 Sep 2025 15:22:55 +0200	[thread overview]
Message-ID: <20250910132331.506716-1-d.csapak@proxmox.com> (raw)

this was a leftover `todo!()`, a remote has no concept of a template so return
false if a remote should be filtered by that category.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 server/src/api/resources.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index dcdf0ea..db705b8 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -125,7 +125,7 @@ fn remote_matches_search_term(remote_name: &str, online: Option<bool>, term: &Se
                 Some(false) => category.matches("offline", &term.value),
                 None => true,
             },
-            MatchCategory::Template => todo!(),
+            MatchCategory::Template => false,
         },
         Some(Err(_)) => false,
         None => remote_name.contains(&term.value) || "remote".starts_with(&term.value),
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-09-10 13:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 13:22 Dominik Csapak [this message]
2025-09-10 13:22 ` [pdm-devel] [PATCH datacenter-manager 2/2] server: api: resources: improve search when searching for remotes Dominik Csapak
2025-09-10 15:12 ` [pdm-devel] applied: [PATCH datacenter-manager 1/2] server: api: resources: implement remote match for template Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250910132331.506716-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal